Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add chinese hyphenated name #277

Merged
merged 3 commits into from
Apr 6, 2022
Merged

Conversation

LeToNode
Copy link
Contributor

add chinese hyphenated name

add chinese hyphenated name
@LeToNode LeToNode requested a review from a team as a code owner January 24, 2022 05:47
@Shinigami92
Copy link
Member

Thanks for these
Currently we are aiming for code stability for the base of the code, so please be patient with us until we released 6.0.0


Auto-Translated:
感谢这些
目前我们的目标是代码基础的代码稳定性,所以请耐心等待我们发布 6.0.0

@Shinigami92 Shinigami92 changed the title add chinese hyphenated name feat: add chinese hyphenated name Jan 24, 2022
@Shinigami92 Shinigami92 added the p: 1-normal Nothing urgent label Jan 24, 2022
@Shinigami92 Shinigami92 added c: feature Request for new feature c: locale Permutes locale definitions and removed c: feature Request for new feature labels Mar 15, 2022
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #277 (30f97d2) into main (5beac4b) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 30f97d2 differs from pull request most recent head 29fa133. Consider uploading reports for the commit 29fa133 to get more accurate results

@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
- Coverage   99.34%   99.34%   -0.01%     
==========================================
  Files        1921     1921              
  Lines      176656   176550     -106     
  Branches      905      912       +7     
==========================================
- Hits       175503   175393     -110     
- Misses       1097     1101       +4     
  Partials       56       56              
Impacted Files Coverage Δ
src/locales/zh_CN/name/last_name.ts 100.00% <100.00%> (ø)
src/address.ts 99.09% <0.00%> (-0.72%) ⬇️
src/iban.ts 100.00% <0.00%> (ø)
src/lorem.ts 100.00% <0.00%> (ø)
src/definitions/address.ts 100.00% <0.00%> (ø)
src/locales/ar/address/street_address.ts 100.00% <0.00%> (ø)
src/locales/az/address/street_address.ts 100.00% <0.00%> (ø)
src/locales/cz/address/street_address.ts 100.00% <0.00%> (ø)
src/locales/de/address/street_address.ts 100.00% <0.00%> (ø)
src/locales/en/address/street_address.ts 100.00% <0.00%> (ø)
... and 27 more

@Shinigami92 Shinigami92 requested review from a team April 5, 2022 16:00
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format wise this looks good. I could only check the content via google translate.

Copy link
Member

@import-brain import-brain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ST-DDT No need to worry, all of these names check out and are valid surnames.

@Shinigami92 Shinigami92 enabled auto-merge (squash) April 6, 2022 07:49
@Shinigami92 Shinigami92 merged commit 40c9d5a into faker-js:main Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants