Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: append more korean dataset and delete wrong dataset #573

Merged
merged 6 commits into from
Apr 5, 2022
Merged

feat: append more korean dataset and delete wrong dataset #573

merged 6 commits into from
Apr 5, 2022

Conversation

hyesungoh
Copy link
Contributor

Hello there !

I append some korean dataset and delete wrong dataset what cities in street dataset.

@hyesungoh hyesungoh requested a review from a team as a code owner February 26, 2022 15:33
@import-brain import-brain added c: feature Request for new feature p: 1-normal Nothing urgent labels Feb 26, 2022
ST-DDT
ST-DDT previously approved these changes Feb 26, 2022
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format wise, this looks good to me. But we need someone that is familiar with korean to check these.

src/locales/ko/address/street_root.ts Show resolved Hide resolved
@ST-DDT ST-DDT added this to the v6.2 - New small features milestone Feb 26, 2022
@ST-DDT ST-DDT requested a review from a team February 26, 2022 19:37
@codecov
Copy link

codecov bot commented Feb 26, 2022 •
edited

Codecov Report

Merging #573 (57797fc) into main (b3a9abc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 57797fc differs from pull request most recent head 084a105. Consider uploading reports for the commit 084a105 to get more accurate results

@@           Coverage Diff           @@
##             main     #573   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files        1921     1921           
  Lines      176529   176536    +7     
  Branches      912      912           
=======================================
+ Hits       175372   175379    +7     
  Misses       1101     1101           
  Partials       56       56
Impacted Files Coverage Δ
src/locales/ko/address/city_name.ts 100.00% <100.00%> (ø)
src/locales/ko/address/street_root.ts 100.00% <100.00%> (ø)
src/locales/ko/name/first_name.ts 100.00% <100.00%> (ø)
src/locales/ro/address/index.ts 100.00% <100.00%> (ø)

prisis
prisis previously approved these changes Mar 1, 2022
View reviewed changes
@prisis
Copy link
Member

prisis commented Mar 1, 2022

Checked it with google translate and google search to find the locations

import-brain
import-brain previously approved these changes Mar 5, 2022
View reviewed changes
@Shinigami92 Shinigami92 added c: locale Permutes locale definitions and removed c: feature Request for new feature labels Mar 18, 2022
Shinigami92
Shinigami92 previously approved these changes Apr 5, 2022
View reviewed changes
@Shinigami92 Shinigami92 dismissed stale reviews from import-brain, prisis, ST-DDT, and themself via 084a105 April 5, 2022 15:31
@Shinigami92 Shinigami92 requested a review from ST-DDT April 5, 2022 15:31
@Shinigami92 Shinigami92 merged commit acaedb3 into faker-js:main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@prisis prisis prisis left review comments

@import-brain import-brain import-brain left review comments

Assignees

@hyesungoh hyesungoh

Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent
Projects
None yet
Milestone
v6.2 - New small features
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hyesungoh @prisis @ST-DDT @Shinigami92 @import-brain