Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add some en locale product names #686

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Conversation

import-brain
Copy link
Member

No description provided.

@import-brain import-brain added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Mar 26, 2022
@import-brain import-brain requested a review from a team March 26, 2022 16:03
@import-brain import-brain requested a review from a team as a code owner March 26, 2022 16:03
@codecov
Copy link

codecov bot commented Mar 26, 2022

Codecov Report

Merging #686 (920b1d8) into main (b34ef46) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 920b1d8 differs from pull request most recent head f9d1731. Consider uploading reports for the commit f9d1731 to get more accurate results

@@           Coverage Diff            @@
##             main     #686    +/-   ##
========================================
  Coverage   99.34%   99.34%            
========================================
  Files        1918     1923     +5     
  Lines      176475   176890   +415     
  Branches      912      897    -15     
========================================
+ Hits       175318   175735   +417     
+ Misses       1101     1099     -2     
  Partials       56       56            
Impacted Files Coverage Δ
src/locales/en/commerce/product_name.ts 100.00% <100.00%> (ø)
src/helpers.ts 99.12% <0.00%> (-0.16%) ⬇️
src/index.ts 94.87% <0.00%> (-0.13%) ⬇️
src/random.ts 99.44% <0.00%> (-0.03%) ⬇️
src/fake.ts 100.00% <0.00%> (ø)
src/word.ts 100.00% <0.00%> (ø)
src/faker.ts 100.00% <0.00%> (ø)
src/lorem.ts 100.00% <0.00%> (ø)
src/commerce.ts 100.00% <0.00%> (ø)
src/datatype.ts 100.00% <0.00%> (ø)
... and 28 more

@Shinigami92 Shinigami92 added the s: accepted Accepted feature / Confirmed bug label Mar 26, 2022
@Shinigami92 Shinigami92 enabled auto-merge (squash) April 5, 2022 15:13
@Shinigami92 Shinigami92 merged commit f22b93a into main Apr 5, 2022
@Shinigami92 Shinigami92 deleted the en_product_names branch April 5, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants