Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove faker default export #799

Merged
merged 8 commits into from
May 4, 2022
Merged

refactor!: remove faker default export #799

merged 8 commits into from
May 4, 2022

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent do NOT merge yet Do not merge this PR into the target branch yet s: accepted Accepted feature / Confirmed bug c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs labels Apr 7, 2022
@Shinigami92 Shinigami92 added this to the v7 - Next Major milestone Apr 7, 2022
@Shinigami92 Shinigami92 requested a review from a team as a code owner April 7, 2022 13:40
@Shinigami92 Shinigami92 self-assigned this Apr 7, 2022
@Shinigami92 Shinigami92 linked an issue Apr 7, 2022 that may be closed by this pull request
Remove faker default export from src/index #777
Closed
@Shinigami92 Shinigami92 requested a review from a team April 7, 2022 13:50
@codecov
Copy link

codecov bot commented Apr 7, 2022 •
edited

Codecov Report

Merging #799 (cc621c2) into main (63f6361) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head cc621c2 differs from pull request most recent head c495697. Consider uploading reports for the commit c495697 to get more accurate results

@@           Coverage Diff           @@
##             main     #799   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files        1957     1957           
  Lines      209770   209768    -2     
  Branches      877      878    +1     
=======================================
+ Hits       209081   209082    +1     
+ Misses        669      666    -3     
  Partials       20       20
Impacted Files Coverage Δ
src/index.ts 97.29% <ø> (-0.14%) ⬇️
src/modules/finance/index.ts 100.00% <0.00%> (+0.68%) ⬆️

@ST-DDT
Copy link
Member

ST-DDT commented Apr 7, 2022

Why exactly are you removing the switch imports docs?

@Shinigami92
Copy link
Member Author

Shinigami92 commented Apr 7, 2022 •
edited

Why exactly are you removing the switch imports docs?

Because this is targeted for v7 and we will not need to further document such stuff from then on.

Nevermind, I just used ctrl+f and did not see that this is migration-guide-v5->v6

@Shinigami92 Shinigami92 force-pushed the 777-remove-faker-default-export-from-src-index branch from 61146c7 to 7cec578 Compare April 19, 2022 17:45
@Shinigami92 Shinigami92 force-pushed the 777-remove-faker-default-export-from-src-index branch from 7cec578 to 445783f Compare May 3, 2022 14:00
@Shinigami92 Shinigami92 removed the do NOT merge yet Do not merge this PR into the target branch yet label May 3, 2022
@Shinigami92 Shinigami92 requested review from a team May 3, 2022 21:10
@Shinigami92 Shinigami92 enabled auto-merge (squash) May 4, 2022 11:04
@Shinigami92 Shinigami92 merged commit 39b74c0 into main May 4, 2022
@Shinigami92 Shinigami92 deleted the 777-remove-faker-default-export-from-src-index branch May 4, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@prisis prisis prisis approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7.0 - Structural Breaking Changes
Development

Successfully merging this pull request may close these issues.

Remove faker default export from src/index
3 participants
@Shinigami92 @ST-DDT @prisis