Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Maryland (MD) wrong postal code #804

Merged
merged 3 commits into from
Apr 8, 2022

Conversation

miguelmontanod
Copy link
Contributor

The Zip code 20331 is from Washington, DC. I took this one from https://worldpopulationreview.com/zips/maryland

The Zip code 20331 is from Washington, DC. I took this one from https://worldpopulationreview.com/zips/maryland
@miguelmontanod miguelmontanod requested a review from a team as a code owner April 8, 2022 03:47
@miguelmontanod miguelmontanod changed the title Update postcode_by_state.ts Fix: Update postcode_by_state.ts Apr 8, 2022
@miguelmontanod miguelmontanod changed the title Fix: Update postcode_by_state.ts Fix: Maryland (MD) wrong postal code Apr 8, 2022
@Shinigami92 Shinigami92 changed the title Fix: Maryland (MD) wrong postal code fix: Maryland (MD) wrong postal code Apr 8, 2022
@Shinigami92 Shinigami92 added c: bug Something isn't working p: 1-normal Nothing urgent labels Apr 8, 2022
@Shinigami92 Shinigami92 added this to the v6.2 - New small features milestone Apr 8, 2022
Shinigami92
Shinigami92 previously approved these changes Apr 8, 2022
@Shinigami92 Shinigami92 requested review from ST-DDT and a team April 8, 2022 06:50
@Shinigami92
Copy link
Member

@ST-DDT I remember vaguely you had somewhere something regarding postal codes. Is this PR in any kind related to this one?

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #804 (16f00fc) into main (78a30fb) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #804   +/-   ##
=======================================
  Coverage   99.35%   99.35%           
=======================================
  Files        1921     1921           
  Lines      179085   179085           
  Branches      909      909           
=======================================
  Hits       177932   177932           
  Misses       1097     1097           
  Partials       56       56           
Impacted Files Coverage Δ
src/locales/en_US/address/postcode_by_state.ts 100.00% <100.00%> (ø)

ST-DDT
ST-DDT previously approved these changes Apr 8, 2022
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I searched that page and noticed, that 20901-20906 seems to work as well.
Should we allow them all for more variation?
(I'm not familiar with us post codes)

@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Apr 8, 2022
@Shinigami92 Shinigami92 added the s: awaiting more info Additional information are requested label Apr 8, 2022
import-brain
import-brain previously approved these changes Apr 8, 2022
@miguelmontanod
Copy link
Contributor Author

miguelmontanod commented Apr 8, 2022

Looks good to me. I searched that page and noticed, that 20901-20906 seems to work as well. Should we allow them all for more variation? (I'm not familiar with us post codes)

This sounds better, I've tested it and it looks like there are more. We can safely set it to 20899-20908

@Shinigami92 Shinigami92 removed the s: awaiting more info Additional information are requested label Apr 8, 2022
@ST-DDT ST-DDT requested review from Shinigami92 and a team April 8, 2022 16:17
@Shinigami92 Shinigami92 merged commit 4ac2a04 into faker-js:main Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants