Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated mime-db to 1.52.0 #808

Merged
merged 6 commits into from
Apr 8, 2022
Merged

Conversation

prisis
Copy link
Member

@prisis prisis commented Apr 8, 2022

feat: Added mime-db as dev dep
feat: Added script to sync mime-db

Im proposing a different approach to update the mime-types

feat: Added mime-db as dev dep
feat: Added script to sync mime-db
@prisis prisis requested a review from a team as a code owner April 8, 2022 10:36
@prisis prisis self-assigned this Apr 8, 2022
@prisis prisis added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Apr 8, 2022
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #808 (3d3e7e9) into main (a572709) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             main     #808     +/-   ##
=========================================
  Coverage   99.34%   99.35%             
=========================================
  Files        1921     1921             
  Lines      177120   179085   +1965     
  Branches      909      909             
=========================================
+ Hits       175967   177932   +1965     
  Misses       1097     1097             
  Partials       56       56             
Impacted Files Coverage Δ
src/locales/en/system/mimeTypes.ts 100.00% <ø> (ø)

package.json Outdated Show resolved Hide resolved
pnpm-lock.yaml Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 added the s: accepted Accepted feature / Confirmed bug label Apr 8, 2022
@Shinigami92 Shinigami92 added this to the v6.2 - New small features milestone Apr 8, 2022
@Shinigami92 Shinigami92 linked an issue Apr 8, 2022 that may be closed by this pull request
@Shinigami92 Shinigami92 requested review from Shinigami92 and a team April 8, 2022 12:32
Shinigami92
Shinigami92 previously approved these changes Apr 8, 2022
@Shinigami92 Shinigami92 requested a review from a team April 8, 2022 12:33
src/locales/en/system/mimeTypes.ts Outdated Show resolved Hide resolved
scripts/copyMimeTypes.ts Outdated Show resolved Hide resolved
prisis and others added 2 commits April 8, 2022 14:56
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
@Shinigami92 Shinigami92 requested a review from ST-DDT April 8, 2022 13:23
@Shinigami92 Shinigami92 changed the title feat: Updated mimeType extensions feat: updated mime-db to 1.52.0 Apr 8, 2022
@Shinigami92 Shinigami92 enabled auto-merge (squash) April 8, 2022 15:25
@Shinigami92 Shinigami92 merged commit 78a30fb into faker-js:main Apr 8, 2022
@HonzaMac
Copy link
Contributor

HonzaMac commented Apr 8, 2022

Thank you. Great idea.

@pkuczynski
Copy link
Member

@prisis just out of the interest: why do we copy it to our source instead of just keeping it as dependency and importing like any other module?

@prisis
Copy link
Member Author

prisis commented Apr 8, 2022

It's the first step, i would like to discuss how we will handle dependencies in the future for faker.

For now I just want to provide a way without adding something new :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update embedded mime types
5 participants