Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: phone IMEI #829

Merged
merged 7 commits into from
Apr 10, 2022
Merged

feat: phone IMEI #829

merged 7 commits into from
Apr 10, 2022

Conversation

import-brain
Copy link
Member

closes #826

@import-brain import-brain added c: feature Request for new feature p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Apr 10, 2022
@import-brain import-brain requested a review from a team April 10, 2022 15:04
@import-brain import-brain self-assigned this Apr 10, 2022
@import-brain import-brain requested a review from a team as a code owner April 10, 2022 15:04
@codecov
Copy link

codecov bot commented Apr 10, 2022 •
edited

Codecov Report

Merging #829 (45f906c) into main (301ad54) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #829   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files        1921     1921           
  Lines      179157   179170   +13     
  Branches      894      895    +1     
=======================================
+ Hits       177980   177993   +13     
  Misses       1121     1121           
  Partials       56       56
Impacted Files Coverage Δ
src/phone.ts 100.00% <100.00%> (ø)

pkuczynski
pkuczynski previously requested changes Apr 10, 2022
View reviewed changes
src/phone.ts Outdated Show resolved Hide resolved
src/phone.ts Outdated Show resolved Hide resolved
src/phone.ts Show resolved Hide resolved
Shinigami92
Shinigami92 reviewed Apr 10, 2022
View reviewed changes
test/phone.spec.ts Outdated Show resolved Hide resolved
import-brain and others added 2 commits April 10, 2022 11:18
@import-brain @pkuczynski
Apply suggestions from @pkuczynski's review
42126df 
Co-authored-by: Piotr Kuczynski <piotr.kuczynski@gmail.com>
@import-brain @Shinigami92
Apply suggestion from @Shinigami92's review
7070dcc 
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Shinigami92
Shinigami92 previously approved these changes Apr 10, 2022
View reviewed changes
ST-DDT
ST-DDT requested changes Apr 10, 2022
View reviewed changes
test/phone.spec.ts Show resolved Hide resolved
test/phone.spec.ts Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 changed the title feat: phone.imei() feat: phone IMEI Apr 10, 2022
@Shinigami92 Shinigami92 requested a review from ST-DDT April 10, 2022 15:54
@ST-DDT ST-DDT requested review from a team April 10, 2022 16:27
@Shinigami92 Shinigami92 enabled auto-merge (squash) April 10, 2022 16:35
@Shinigami92 Shinigami92 merged commit c25ecd0 into main Apr 10, 2022
@Shinigami92 Shinigami92 deleted the feat_imei branch April 10, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@pkuczynski pkuczynski Awaiting requested review from pkuczynski

Assignees

@import-brain import-brain

Labels
c: feature Request for new feature p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Milestone
v6.2 - New small features
Development

Successfully merging this pull request may close these issues.

Random IMEI number
4 participants
@import-brain @pkuczynski @ST-DDT @Shinigami92