Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: remove node v12 support #850

Merged
merged 1 commit into from
May 3, 2022
Merged

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Apr 20, 2022

Fully remove support for node v12

For upgrade to node v18 see #847

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs labels Apr 20, 2022
@Shinigami92 Shinigami92 added this to the v7 - Next Major milestone Apr 20, 2022
@Shinigami92 Shinigami92 self-assigned this Apr 20, 2022
@Shinigami92 Shinigami92 added the do NOT merge yet Do not merge this PR into the target branch yet label Apr 20, 2022
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #850 (80e2454) into main (a2da7c4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #850   +/-   ##
=======================================
  Coverage   99.13%   99.13%           
=======================================
  Files        1958     1958           
  Lines      210793   210793           
  Branches      906      906           
=======================================
  Hits       208964   208964           
  Misses       1753     1753           
  Partials       76       76           

@Shinigami92 Shinigami92 removed the do NOT merge yet Do not merge this PR into the target branch yet label May 3, 2022
@Shinigami92 Shinigami92 marked this pull request as ready for review May 3, 2022 13:54
@Shinigami92 Shinigami92 requested a review from a team as a code owner May 3, 2022 13:54
@Shinigami92 Shinigami92 requested a review from a team May 3, 2022 13:54
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label May 3, 2022
@ST-DDT ST-DDT requested a review from a team May 3, 2022 13:55
@Shinigami92 Shinigami92 merged commit cc9aec7 into main May 3, 2022
@Shinigami92 Shinigami92 deleted the remove-node-12-support branch May 3, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants