Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove deprecations #916

Merged
merged 4 commits into from
May 4, 2022
Merged

refactor!: remove deprecations #916

merged 4 commits into from
May 4, 2022

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added the c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs label May 3, 2022
@Shinigami92 Shinigami92 self-assigned this May 3, 2022
@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels May 3, 2022
@codecov
Copy link

codecov bot commented May 3, 2022 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (main@100a1ea). Click here to learn what that means.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #916   +/-   ##
=======================================
  Coverage        ?   99.67%           
=======================================
  Files           ?     1957           
  Lines           ?   209770           
  Branches        ?      877           
=======================================
  Hits            ?   209081           
  Misses          ?      669           
  Partials        ?       20
Impacted Files Coverage Δ
src/faker.ts 100.00% <ø> (ø)
src/modules/datatype/index.ts 100.00% <ø> (ø)
src/modules/helpers/index.ts 98.31% <ø> (ø)
src/modules/finance/index.ts 99.31% <100.00%> (ø)
src/modules/name/index.ts 100.00% <100.00%> (ø)
src/modules/random/index.ts 100.00% <100.00%> (ø)
src/modules/unique/index.ts 100.00% <100.00%> (ø)

@Shinigami92 Shinigami92 marked this pull request as ready for review May 3, 2022 20:48
@Shinigami92 Shinigami92 requested a review from a team May 3, 2022 20:48
@Shinigami92 Shinigami92 requested a review from a team as a code owner May 3, 2022 20:48
@ST-DDT
Copy link
Member

ST-DDT commented May 3, 2022

Please communicate this also here:
#805 (reply in thread)

@Shinigami92
Copy link
Member Author

Please communicate this also here: #805 (reply in thread)

done ✔️

@Shinigami92 Shinigami92 requested a review from a team May 4, 2022 06:14
@ST-DDT ST-DDT requested review from a team May 4, 2022 09:42
@Shinigami92 Shinigami92 merged commit 683ee34 into main May 4, 2022
@Shinigami92 Shinigami92 deleted the remove-deprecations branch May 4, 2022 09:48
@Shinigami92 Shinigami92 mentioned this pull request May 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkuczynski pkuczynski pkuczynski approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7.0 - Structural Breaking Changes
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Shinigami92 @ST-DDT @pkuczynski @xDivisionByZerox