Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add casing option #955

Merged
merged 9 commits into from
May 21, 2022
Merged

feat: add casing option #955

merged 9 commits into from
May 21, 2022

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented May 14, 2022 •
edited

requested in #819

@Shinigami92 Shinigami92 added the c: feature Request for new feature label May 14, 2022
@Shinigami92 Shinigami92 added this to the v7 - Current Major milestone May 14, 2022
@Shinigami92 Shinigami92 self-assigned this May 14, 2022
@Shinigami92 Shinigami92 added the p: 1-normal Nothing urgent label May 14, 2022
ST-DDT
ST-DDT reviewed May 14, 2022
View reviewed changes
src/modules/random/index.ts Outdated Show resolved Hide resolved
src/modules/random/index.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 15, 2022 •
edited

Codecov Report

Merging #955 (6a09de4) into main (5af79f4) will decrease coverage by 0.00%.
The diff coverage is 91.83%.

@@            Coverage Diff             @@
##             main     #955      +/-   ##
==========================================
- Coverage   99.65%   99.65%   -0.01%     
==========================================
  Files        1988     1988              
  Lines      210187   210192       +5     
  Branches      889      904      +15     
==========================================
- Hits       209471   209468       -3     
- Misses        697      705       +8     
  Partials       19       19
Impacted Files Coverage Δ
src/modules/random/index.ts 97.68% <91.30%> (-2.32%) ⬇️
src/modules/vehicle/index.ts 100.00% <100.00%> (ø)

@Shinigami92 Shinigami92 added the needs test More tests are needed label May 15, 2022
@Shinigami92 Shinigami92 mentioned this pull request May 18, 2022
Merged
@Shinigami92 Shinigami92 removed the needs test More tests are needed label May 18, 2022
@Shinigami92
Copy link
Member Author

ready for review, but maybe I need to add some more tests
lets see what's not covered

@Shinigami92 Shinigami92 marked this pull request as ready for review May 18, 2022 17:33
@Shinigami92 Shinigami92 requested a review from a team as a code owner May 18, 2022 17:33
@Shinigami92 Shinigami92 requested a review from a team May 18, 2022 17:33
@Shinigami92 Shinigami92 requested a review from ST-DDT May 18, 2022 18:07
ST-DDT
ST-DDT previously approved these changes May 18, 2022
View reviewed changes
@ST-DDT ST-DDT requested a review from a team May 18, 2022 22:39
import-brain
import-brain previously approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@import-brain import-brain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer it to be phrased like this, seems a little bit clearer

Other than that, LGTM

src/modules/random/index.ts Outdated Show resolved Hide resolved
@Shinigami92 @import-brain
Update src/modules/random/index.ts
5fa404f 
Co-authored-by: Eric Cheng <ericcheng9316@gmail.com>
@Shinigami92 Shinigami92 dismissed stale reviews from import-brain and ST-DDT via 5fa404f May 19, 2022 14:36
@import-brain import-brain requested a review from a team May 19, 2022 18:12
pkuczynski
pkuczynski approved these changes May 19, 2022
View reviewed changes
src/modules/random/index.ts Show resolved Hide resolved
src/modules/random/index.ts Show resolved Hide resolved
@ST-DDT ST-DDT requested review from a team May 20, 2022 11:03
@Shinigami92 Shinigami92 enabled auto-merge (squash) May 21, 2022 14:27
@Shinigami92 Shinigami92 merged commit 4c0e418 into main May 21, 2022
@Shinigami92 Shinigami92 deleted the add-casing-option branch May 21, 2022 14:30
@xDivisionByZerox xDivisionByZerox added the m: random Something is referring to the random module label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkuczynski pkuczynski pkuczynski approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@import-brain import-brain import-brain approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: feature Request for new feature m: random Something is referring to the random module p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Shinigami92 @pkuczynski @ST-DDT @import-brain @xDivisionByZerox