Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add date.birthdate #962

Merged
merged 6 commits into from
May 17, 2022
Merged

feat: add date.birthdate #962

merged 6 commits into from
May 17, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented May 15, 2022

This splits the birthdate part from #182 into its own PR.

Docs Preview

grafik

ST-DDT and others added 3 commits May 15, 2022 17:01
Co-authored-by: Priyansh <bobbyskhs@gmail.com>
Co-authored-by: Shinigami <chrissi92@hotmail.de>
@ST-DDT ST-DDT added c: feature Request for new feature p: 1-normal Nothing urgent labels May 15, 2022
@ST-DDT ST-DDT requested review from a team May 15, 2022 15:21
@ST-DDT ST-DDT self-assigned this May 15, 2022
@codecov
Copy link

codecov bot commented May 15, 2022

Codecov Report

Merging #962 (915e2cb) into main (f9a1415) will increase coverage by 0.00%.
The diff coverage is 95.00%.

@@           Coverage Diff           @@
##             main     #962   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files        1970     1970           
  Lines      209928   209988   +60     
  Branches      875      885   +10     
=======================================
+ Hits       209212   209272   +60     
  Misses        697      697           
  Partials       19       19           
Impacted Files Coverage Δ
src/modules/date/index.ts 99.05% <95.00%> (-0.95%) ⬇️
src/modules/finance/index.ts 100.00% <0.00%> (+0.68%) ⬆️

@ST-DDT ST-DDT enabled auto-merge (squash) May 17, 2022 06:45
@ST-DDT ST-DDT merged commit 5e66d96 into main May 17, 2022
@ST-DDT ST-DDT deleted the feature/date/birthdate branch May 17, 2022 07:09
@xDivisionByZerox xDivisionByZerox added the m: date Something is referring to the date module label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature m: date Something is referring to the date module p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants