Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert type exports for module NodeNext, Node16 (#979) #989

Merged
merged 1 commit into from
May 23, 2022

Conversation

Shinigami92
Copy link
Member

This reverts commit 73db3a7.

@Shinigami92 Shinigami92 requested a review from a team as a code owner May 23, 2022 21:07
@Shinigami92 Shinigami92 self-assigned this May 23, 2022
@Shinigami92 Shinigami92 added the p: 3-urgent Fix and release ASAP label May 23, 2022
@Shinigami92 Shinigami92 requested a review from a team May 23, 2022 21:07
@Shinigami92 Shinigami92 changed the title Revert "fix: type exports for module NodeNext, Node16 (#979)" fix: revert type exports for module NodeNext, Node16 (#979) May 23, 2022
@Shinigami92 Shinigami92 added c: bug Something isn't working s: accepted Accepted feature / Confirmed bug labels May 23, 2022
@Shinigami92 Shinigami92 enabled auto-merge (squash) May 23, 2022 21:10
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #989 (1336f80) into main (0411799) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #989      +/-   ##
==========================================
- Coverage   99.67%   99.67%   -0.01%     
==========================================
  Files        2110     2110              
  Lines      225732   225732              
  Branches      979      978       -1     
==========================================
- Hits       224992   224989       -3     
- Misses        720      723       +3     
  Partials       20       20              
Impacted Files Coverage Δ
src/modules/finance/index.ts 99.31% <0.00%> (-0.69%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working p: 3-urgent Fix and release ASAP s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants