feat: add en_CA city_name (close #983) #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
approved these changes
May 24, 2022
Shinigami92
added
p: 1-normal
Codecov Report
@@ Coverage Diff @@
## main #992 +/- ##
========================================
Coverage 99.67% 99.67%
========================================
Files 2110 2111 +1
Lines 225732 225957 +225
Branches 978 978
========================================
+ Hits 224989 225214 +225
Misses 723 723
Partials 20 20
|
import-brain
approved these changes
May 24, 2022
ST-DDT
approved these changes
May 24, 2022
Minozzzi
pushed a commit
to Minozzzi/faker
that referenced
this pull request
Jul 19, 2022
Co-authored-by: Wing Leung Choi <wchoi@and.digital>
xDivisionByZerox
added
the
m: location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #983
Motivation: #983 (comment)
add Canada city_name
contains the following special characters
-e.g.'Baie-Comeau'âinChâteauguay,’inVal-d’Orcity list is based on https://www.britannica.com/topic/list-of-cities-and-towns-in-Canada-2038873