From e038e349dc6bf7bdf514d6293f7ad60b4539f8a6 Mon Sep 17 00:00:00 2001 From: "Mona,Lisa" Date: Thu, 4 May 2023 21:00:52 +0700 Subject: [PATCH 1/3] fix(docs): fix faker 7.x.x old code for locale migration --- docs/guide/upgrading.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/guide/upgrading.md b/docs/guide/upgrading.md index 03d1acb9a61..b6b87faf0e6 100644 --- a/docs/guide/upgrading.md +++ b/docs/guide/upgrading.md @@ -30,7 +30,7 @@ import { faker } from '@faker-js/faker'; faker.setLocale('de_CH'); // or faker.locale = 'de_CH'; -faker.fallbackLocale = 'en'; +faker.localeFallback = 'en'; ``` **New** @@ -44,11 +44,11 @@ This also fixes issues where more than two locales are required: **Old** ```ts -import { faker } from '@faker-js/faker'; - +import { faker, Faker } from '@faker-js/faker'; +const { de_CH, de, en } = faker.locales; const customFaker = new Faker({ locale: 'de_CH', // the expected locale - fallbackLocale: 'de', // ensure we have a German fallbacks for addresses + localeFallback: 'de', // ensure we have a German fallbacks for addresses locales: { de_CH, de, en }, }); const a = customFaker.internet.email(); From bfefe64e315376c3a0e56dfa059a1511b5014c1d Mon Sep 17 00:00:00 2001 From: Matt Mayer <152770+matthewmayer@users.noreply.github.com> Date: Sat, 6 May 2023 18:02:16 +0700 Subject: [PATCH 2/3] Update docs/guide/upgrading.md Co-authored-by: DivisionByZero --- docs/guide/upgrading.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/guide/upgrading.md b/docs/guide/upgrading.md index b6b87faf0e6..9fd95c95512 100644 --- a/docs/guide/upgrading.md +++ b/docs/guide/upgrading.md @@ -45,6 +45,7 @@ This also fixes issues where more than two locales are required: ```ts import { faker, Faker } from '@faker-js/faker'; + const { de_CH, de, en } = faker.locales; const customFaker = new Faker({ locale: 'de_CH', // the expected locale From ed638ea4997c33c1d6292660cb7414c440f2727b Mon Sep 17 00:00:00 2001 From: Matt Mayer <152770+matthewmayer@users.noreply.github.com> Date: Sat, 6 May 2023 18:08:38 +0700 Subject: [PATCH 3/3] remove s from fallback --- docs/guide/upgrading.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/guide/upgrading.md b/docs/guide/upgrading.md index 9fd95c95512..2531f484a0d 100644 --- a/docs/guide/upgrading.md +++ b/docs/guide/upgrading.md @@ -49,7 +49,7 @@ import { faker, Faker } from '@faker-js/faker'; const { de_CH, de, en } = faker.locales; const customFaker = new Faker({ locale: 'de_CH', // the expected locale - localeFallback: 'de', // ensure we have a German fallbacks for addresses + localeFallback: 'de', // ensure we have a German fallback for addresses locales: { de_CH, de, en }, }); const a = customFaker.internet.email();