Approved label not automatically added to kernel-crawler repo #1118

FedeDP · 2023-05-02T07:52:46Z

Describe the bug

I have to manually add the approved label to kernel-crawler PRs.

How to reproduce it

Approve any PR on kernel-crawler repo :)

Expected behaviour

The approved label should be automatically added.

With @maxgio92 we discovered that there is some issue with the git client:

hook-7bb6858466-gzdrx hook {"client":"git","component":"hook","count":1,"error":"running \"/usr/bin/git\" [clone --mirror github.com/falcosecurity/kernel-crawler /tmp/git65590195/falcosecurity/kernel-crawler.git] returned error exit status 128 with output \"Cloning into bare repository '/tmp/git65590195/falcosecurity/kernel-crawler.git'...\\nfatal: fetch-pack: invalid index-pack output\\n\"","file":"k8s.io/test-infra/prow/git/git.go:580","func":"k8s.io/test-infra/prow/git.retryCmd","level":"debug","msg":"Retrying, if this is not the 3rd try then this will be retried.","severity":"debug","time":"2023-02-03T15:09:11Z"}

I think it is because the kernel-crawler repo hosts the huge json lists for the kernels for supported architectures and we need to somehow tweak the git client config.

The text was updated successfully, but these errors were encountered:

poiana · 2023-07-31T13:32:33Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

FedeDP · 2023-07-31T13:33:07Z

/remove-lifecycle stale

FedeDP · 2023-07-31T13:33:29Z

/remove-lifecycle stale

FedeDP · 2023-10-23T13:33:01Z

So, after we removed the kernels branch, the git clone --mirror being made by hook plugin is now at ~75MB:

git clone --mirror https://github.com/falcosecurity/kernel-crawler
Clone nel repository spoglio 'kernel-crawler.git' in corso...
remote: Enumerating objects: 2361, done.
remote: Counting objects: 100% (571/571), done.
remote: Compressing objects: 100% (275/275), done.
remote: Total 2361 (delta 294), reused 375 (delta 229), pack-reused 1790
Ricezione degli oggetti: 100% (2361/2361), 75.29 MiB | 5.02 MiB/s, fatto.
Risoluzione dei delta: 100% (1383/1383), fatto.

Unfortunately, this is not enough for it to work.
In a kernel-crawler fork, i tried to rewrite entire main history removing big jsons (since at the start of the repo, they were pushed to the main branch); and now the repo size is ~2MB:

git clone --mirror https://github.com/fededp/kernel-crawler
Clone nel repository spoglio 'kernel-crawler.git' in corso...
remote: Enumerating objects: 1875, done.
remote: Counting objects: 100% (517/517), done.
remote: Compressing objects: 100% (357/357), done.
remote: Total 1875 (delta 193), reused 476 (delta 159), pack-reused 1358
Ricezione degli oggetti: 100% (1875/1875), 2.10 MiB | 3.06 MiB/s, fatto.
Risoluzione dei delta: 100% (1058/1058), fatto.

.
So, i think we'll need to force push main branch.
/cc @leogr @maxgio92 @LucaGuerra

I will need the help of an admin to do so.

FedeDP · 2023-10-23T13:34:45Z

Using git, it will be done like so:

git filter-branch -f --index-filter "git rm -rf --cached --ignore-unmatch kernels/" HEAD
git push origin HEAD --force-with-lease

FedeDP · 2023-10-23T14:04:35Z

So, the work was done; see for example this main commit: falcosecurity/kernel-crawler@4438279

But the end result is a bit different than expected, sizing around ~45MB:

git clone --mirror https://github.com/falcosecurity/kernel-crawler
Clone nel repository spoglio 'kernel-crawler.git' in corso...
remote: Enumerating objects: 2684, done.
remote: Counting objects: 100% (2684/2684), done.
remote: Compressing objects: 100% (830/830), done.
remote: Total 2684 (delta 1718), reused 2543 (delta 1671), pack-reused 0
Ricezione degli oggetti: 100% (2684/2684), 45.87 MiB | 5.06 MiB/s, fatto.
Risoluzione dei delta: 100% (1718/1718), fatto.

Investigating.

FedeDP · 2023-10-23T14:14:46Z

For reference, a git clone --mirror of libs accounts for ~35MB.
There are no tags nor stale branches in kernel-crawler with big jsons; i don't really get this.

FedeDP · 2023-10-23T14:40:25Z

So, it seems jsons are still referenced somewhere (of course):

git rev-list --objects --all | grep json
177bdb29d7cb55dd4505fcad7a0007bfe61856d0 kernels/aarch64/list.json
965ad4147108c5029395e898ccf461ba041c005b kernels/x86_64/list.json
7b28341c4ac53ab817104075cd62af1b2f871ce0 kernels/aarch64/list.json
7cc73e95ff22468866340e0506d64b228a53f696 kernels/x86_64/list.json
7ada52e6b02702dae8e1204b4e45ebde01514c93 kernels/aarch64/list.json
9de80130013a3020e23ead46f53a5df954d7eebe kernels/x86_64/list.json
9fe2739e52952181a2cbc054266038c0db658ae6 kernels/aarch64/list.json
bc7c078463e2516c741ab3e8a281e4a539972017 kernels/x86_64/list.json
c4fc6ccbdaf699db51513cb7cfbd53c2eac3395f kernels/aarch64/list.json
03e2a731e31f7cbbb61160a09003c76c09556c37 kernels/x86_64/list.json
0cc64ddcb7091c05cc921436c56a3db355b57027 kernels/aarch64/list.json
e16424d453886c6537521b23cc9505aa467115cb kernels/x86_64/list.json
14de7d6c9a1fbb633ed261e72ba7df0b0d00131a kernels/aarch64/list.json
941fa5ff86ac237aac7a4d9862e47f794bc6aaaf kernels/x86_64/list.json
36a173cd61841f05f1b1f98f8006219ffe20678a kernels/aarch64/list.json
97b58cc0aaf6e5c2a359d41fed9d6ddf96722f12 kernels/x86_64/list.json
79ba50511cae9941f6ec7292523603f4fb2ede93 kernels/aarch64/list.json
d7ef54205c135ca8608a631d532771b76034b24e kernels/x86_64/list.json
a972a51e83371e047ef3d3557ccae586659453b5 kernels/aarch64/list.json
614b68865cd93c50abb357d5be412fc10e54fb17 kernels/x86_64/list.json
388dbcaf19db2bc1b45d124d82ee5295d989979d kernels/aarch64/list.json
47c06f73737b0958972257903cee5af8585055b1 kernels/x86_64/list.json
2055de08b7c0a34d68f71d0c89dde61a5c7c339d kernels/aarch64/list.json
c1eac473010235d8648b058e1610ee791ad99919 kernels/x86_64/list.json
51ddcc04923a4cc6de5ff0b9bbed481f46969afb kernels/aarch64/list.json
fd4af955206c2d04cd62199fab8c23f026d284f6 kernels/x86_64/list.json

These are not commits though (eg:

git log -1 --decorate 2055de08b7c0a34d68f71d0c89dde61a5c7c339d

nothing is shown).

EDIT:

LC_ALL="C" git for-each-ref --contains 2055de08b7c0a34d68f71d0c89dde61a5c7c339d
error: object 2055de08b7c0a34d68f71d0c89dde61a5c7c339d is a blob, not a commit
error: no such commit 2055de08b7c0a34d68f71d0c89dde61a5c7c339d

FedeDP · 2023-10-24T09:19:33Z

So, it seems jsons are still referenced somewhere (of course):

So, it seems like these might be related to the number of json pushing PRs that were opened to main: exactly 13 with 2 jsons, so 26 entries (exactly same number seen above).

I think that we correctly cleaned up main, but we couldn't clean up GitHub hidden PRs refs (and we can't force push them either afaik), so their blobs are still there.

Using https://rtyley.github.io/bfg-repo-cleaner/ works, ie: git rev-list does not show any json file anymore, but then we cannot push (neither force push) because it gave us:

git push -f
Enumerazione degli oggetti in corso: 387, fatto.
Conteggio degli oggetti in corso: 100% (188/188), fatto.
Scrittura degli oggetti in corso: 100% (387/387), 35.72 KiB | 35.72 MiB/s, fatto.
387 oggetti totali (188 delta), 188 riutilizzati (188 delta), 199 riutilizzati nel file pack
remote: Resolving deltas: 100% (322/322), completed with 167 local objects.
To github.com:falcosecurity/kernel-crawler.git
 ! [remote rejected] refs/pull/1/head -> refs/pull/1/head (deny updating a hidden ref)
 ! [remote rejected] refs/pull/10/head -> refs/pull/10/head (deny updating a hidden ref)
...

for each opened PR.

maxgio92 · 2023-10-24T13:03:48Z

JFI I think we can do nothing about synthetic references as they're read-only: rtyley/bfg-repo-cleaner#36 (comment)

poiana · 2024-01-22T15:48:20Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

FedeDP · 2024-01-22T16:03:22Z

/remove-lifecycle stale

poiana · 2024-04-21T21:51:55Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

FedeDP · 2024-04-22T06:40:06Z

/remove-lifecycle stale

FedeDP added the kind/bug label May 2, 2023

poiana added the lifecycle/stale label Jul 31, 2023

poiana removed the lifecycle/stale label Jul 31, 2023

This was referenced Oct 16, 2023

new(ci): run update-kernels daily. falcosecurity/kernel-crawler#179

Merged

Build drivers more frequently (ideally every 2 hours) #1255

Closed

FedeDP mentioned this issue Oct 23, 2023

new(kernel_crawler): rename distro keys to match os-release names. falcosecurity/kernel-crawler#185

Closed

FedeDP mentioned this issue Oct 23, 2023

new(kernel_crawler): rename distro keys to match os-release names. falcosecurity/kernel-crawler#188

Merged

poiana added the lifecycle/stale label Jan 22, 2024

poiana removed the lifecycle/stale label Jan 22, 2024

poiana added the lifecycle/stale label Apr 21, 2024

poiana removed the lifecycle/stale label Apr 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Approved label not automatically added to kernel-crawler repo #1118

Approved label not automatically added to kernel-crawler repo #1118

FedeDP commented May 2, 2023 •

edited

poiana commented Jul 31, 2023

FedeDP commented Jul 31, 2023 •

edited

FedeDP commented Jul 31, 2023

FedeDP commented Oct 23, 2023

FedeDP commented Oct 23, 2023

FedeDP commented Oct 23, 2023

FedeDP commented Oct 23, 2023

FedeDP commented Oct 23, 2023 •

edited

FedeDP commented Oct 24, 2023

maxgio92 commented Oct 24, 2023 •

edited

poiana commented Jan 22, 2024

FedeDP commented Jan 22, 2024

poiana commented Apr 21, 2024

FedeDP commented Apr 22, 2024

Approved label not automatically added to kernel-crawler repo #1118

Approved label not automatically added to kernel-crawler repo #1118

Comments

FedeDP commented May 2, 2023 • edited

poiana commented Jul 31, 2023

FedeDP commented Jul 31, 2023 • edited

FedeDP commented Jul 31, 2023

FedeDP commented Oct 23, 2023

FedeDP commented Oct 23, 2023

FedeDP commented Oct 23, 2023

FedeDP commented Oct 23, 2023

FedeDP commented Oct 23, 2023 • edited

FedeDP commented Oct 24, 2023

maxgio92 commented Oct 24, 2023 • edited

poiana commented Jan 22, 2024

FedeDP commented Jan 22, 2024

poiana commented Apr 21, 2024

FedeDP commented Apr 22, 2024

FedeDP commented May 2, 2023 •

edited

FedeDP commented Jul 31, 2023 •

edited

FedeDP commented Oct 23, 2023 •

edited

maxgio92 commented Oct 24, 2023 •

edited