Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

idea: MRE template for issues #33

Closed
2 tasks done
domdomegg opened this issue Dec 19, 2023 · 3 comments 路 Fixed by #34
Closed
2 tasks done

idea: MRE template for issues #33

domdomegg opened this issue Dec 19, 2023 · 3 comments 路 Fixed by #34
Assignees

Comments

@domdomegg
Copy link

domdomegg commented Dec 19, 2023

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the feature has not already been requested

馃殌 Feature Proposal

I think it'd be useful to have a minimal reproducible example template for fastify to help:

  • maintainers triage issues
  • users debugging their own problems

Other projects in the space do this, e.g. Next.js or Headless UI

I don't think we should make this mandatory, given the additional burden for small or obvious bugs. But it might help nail down less clear ones :)

Concretely what this might look like is a template repository in the fastify organisation with a simple hello world fastify app set up.

@Eomm
Copy link
Member

Eomm commented Dec 19, 2023

I think we could use the new gitpod integration for this task!

Ref fastify/fastify#5168

@metcoder95
Copy link
Member

I believe not everybody is aware of the
Minimum Reproducible Example concept; it might be worthwhile to create a small callout within the issue template to set some brief discussion

@jsumners
Copy link
Member

I think it will be difficult to put together a generic template. Maybe adding a note in the issue template will help, but I firmly believe the issue template gets ignored more often than it is read.

I do have two saved replies that apply here, though. The first reply is my generic one:

Please provide a minimal reproducible example. Doing so will help us diagnose your issue. It should be the bare minimum code needed to trigger the issue, and easily runnable without any changes or extra code.

You may use a GitHub repository to host the code if it is too much to fit in a code block (or two).

The second one is the one I use for ldapjs issues, and may be more applicable to the issue under discussion:

Please provide a minimal reproducible example (MRE). Doing so will help us diagnose your issue. It should be the bare minimum code needed to trigger the issue, and easily runnable without any changes or extra code. Please review the integration tests, e.g. issue-940.test.js, for examples of good MREs.

You may use a GitHub repository to host the code if it is too much to fit in a code block (or two).

@Fdawgs Fdawgs self-assigned this Dec 21, 2023
@Fdawgs Fdawgs transferred this issue from fastify/fastify Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants