Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating for v5 #26

Closed
2 tasks done
nrayburn-tech opened this issue Nov 2, 2023 · 4 comments
Closed
2 tasks done

Updating for v5 #26

nrayburn-tech opened this issue Nov 2, 2023 · 4 comments

Comments

@nrayburn-tech
Copy link

nrayburn-tech commented Nov 2, 2023

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the issue has not already been raised

Issue

I'm looking to update this repo for v5. fastify/fastify#5116

Changes Needed (Please let me know if anything might be missing)

  • Pin tap to 16.3.9
  • Update workflows to use v4 (temporarily pointing directly to a git sha)
  • Update engines in package.json to >= 18 Remove engines from package.json
  • Update dependabot config to ignore major tap versions
nrayburn-tech added a commit to nrayburn-tech/accept-negotiator that referenced this issue Nov 2, 2023
Update package.json engines to node >= 18
Pin tap version
Fixes fastify#26
@nrayburn-tech nrayburn-tech mentioned this issue Nov 2, 2023
4 tasks
@jsumners
Copy link
Member

jsumners commented Nov 2, 2023

  • Update engines in package.json to >= 18

My personal opinion is to remove the engines field completely. It is ignored by package managers except to maybe log a warning in the middle of output basically no one reads. But maybe others from @fastify/core have a different opinion.

@metcoder95
Copy link
Member

If it weren't because the warning log gets missed quite easily when installing, I'd say it provides good feedback to the user. But as it is not forced, and anyway fp enforces already specific versions of fastify; that should be enough. So +1 on drop it

@nrayburn-tech
Copy link
Author

Updated the PR, but I think I'm going to leave it as a draft until the workflow v4 tag is available unless there's a reason to merge it in sooner. (Going to follow the same pattern for my other PRs of just leaving them as a draft too.)

@gurgunday
Copy link
Member

I just saw the issue, sorry for taking over!

There are many other repositories available to do an upgrade, so it would still be amazing if you could help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants