Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating for v5 #20

Closed
2 tasks done
nrayburn-tech opened this issue Oct 31, 2023 · 1 comment · Fixed by #21
Closed
2 tasks done

Updating for v5 #20

nrayburn-tech opened this issue Oct 31, 2023 · 1 comment · Fixed by #21

Comments

@nrayburn-tech
Copy link

nrayburn-tech commented Oct 31, 2023

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the issue has not already been raised

Issue

I'm looking to update this repo for v5. fastify/fastify#5116

From what I can tell, all that needs to be updated is pin tap to "16.3.9". I'm not seeing any workflow changes that need to be made, changes for dropping node <= 16, or other dependency updates to be made. If I'm missing something, please let me know.

@jsumners
Copy link
Member

Actually, there's going to be at least one change to the CI configuration. See footnote 1 in fastify/fastify#5116.

I have created the https://github.com/fastify/fast-content-type-parse/tree/next branch so you can target your work to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants