Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release plan for the Ajv reference fix #468

Closed
2 tasks done
mcollina opened this issue Jun 19, 2022 · 5 comments
Closed
2 tasks done

Release plan for the Ajv reference fix #468

mcollina opened this issue Jun 19, 2022 · 5 comments

Comments

@mcollina
Copy link
Member

mcollina commented Jun 19, 2022

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the feature has not already been requested

馃殌 Feature Proposal

Here is my proposal for the release of #462:

  1. ship fast-json-stringify v5 with the above change as a precaution.
  2. release fast-json-stringify-compiler with Remove schema from external schemas聽fast-json-stringify-compiler#14 and the fjs v5 bump; this will me a semver-major release release for fast-json-stringify-compiler.
  3. send a PR to fastify to update all the above in a minor release
  4. close fix: ref with same id in properties聽#464 as won't fix.

Did I understood all the fixes correctly? Is this a feasible plan?

cc @delvedor @jsumners @Eomm @climba03003 @ivan-tymoshenko

Motivation

No response

Example

No response

@Eomm
Copy link
Member

Eomm commented Jun 19, 2022

Did I understood all the fixes correctly? Is this a feasible plan?

Yes, it is.

Just to be sure: will the fast-json-stringify-compiler release a major as well?

@mcollina
Copy link
Member Author

Did I understood all the fixes correctly? Is this a feasible plan?

Yes, it is.

Just to be sure: will the fast-json-stringify-compiler release a major as well?

Yes

@climba03003
Copy link
Member

Good to me. It is easy to revert in fastify when it has large impact.

@jsumners
Copy link
Member

Go for it.

@ivan-tymoshenko
Copy link
Member

PR at Fastify, where it all comes together. Now via git-dependency. fastify/fastify#4049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants