-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fastify autoload throwing errors about ts in projects that don't use ts #266
Comments
4 tasks
I added a reproducible example generated from the fastify-cli: |
Looks like if you simply generate a cjs scaffold that also breaks.
|
@kylerush any ideas on how to fix? |
I've just shipped v5.3.1 with a revert. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prerequisites
Fastify version
4.x.x
Plugin version
5.3.0
Node.js version
18.x
Operating system
macOS
Operating system version (i.e. 20.04, 11.3, 10)
Linux and macOS 12.5.1
Description
It looks like #264 is breaking non-ts fastify projects.
What was previously working now gets the following error:
The accepts plugin mentinoned in the error is very simple and does not use TS
Steps to Reproduce
Try to load the above plugin on a ts free auto-load project set to esm module mode.
Here is a reproducible example generated from the fastify-cli and then converted to esm.
https://github.com/ballpit/fastify-autoload-bug
Downgrading fastify-autoload to 5.2.0 fixes the build.
Expected Behavior
That projects not using TS don't throw errors about ts.
The text was updated successfully, but these errors were encountered: