271: trying to use babel-node when using typescript files #272
Conversation
lasmil
commented
Oct 7, 2022
lasmil
commented
- when dealing with typescript files, we need to make sure the ts-node is being used to autoload components
- closes: babel-node + typescript. Error only with autoloads : throw new Error(@fastify/autoload cannot import plugin at '${file}'. To fix this error compile TypeScript to JavaScript or use 'ts-node' to run your app.) #271
- when dealing with typescript files, we need to make sure the ts-node is being used to autoload components - closes: fastify#271
|
There is a difference between the 2 PRs. In this PR I am using: In the other (reverted) PR we are trying to require ts-node even when the type is not 'typescript'. |
|
approach looks reasonable, let's add tests to confirm it works! |
Still, it didn't convince me why we need to explicitly register The solution should be detect if the current script run under |
|
When I tried with the mentioned project I did indeed needed to install ts-node as a dev dependency. Let me try your solution. |
I have pushed a commit to this PR. I tried to find a better way to detect if the script is running under babel-node but unfortunately I was unable to find it. |
lasmil
changed the title
| url: '/' | ||
| }) | ||
| expect(response.statusCode).toEqual(200) | ||
| expect(JSON.parse(response.payload)).toEqual({ hello: 'world' }) |
There was a problem hiding this comment.
| expect(JSON.parse(response.payload)).toEqual({ hello: 'world' }) | |
| expect(response.json()).toEqual({ hello: 'world' }) |
| beforeAll( done => { | ||
| app.register(AutoLoad, { | ||
| dir: join(__dirname, '../../commonjs/babel-node/routes') | ||
| }) | ||
| app.ready(done) | ||
| }) |
There was a problem hiding this comment.
nit: let's use newer async/await syntax
| fastify.get("/", function () { | ||
| return { foo: "bar" }; | ||
| }) | ||
| }; |
There was a problem hiding this comment.
formatting: let's use quotes consistently, either single or double
| const response = await app.inject({ | ||
| method: 'GET', | ||
| url: '/' | ||
| }) |
There was a problem hiding this comment.
if you're GETting root you don't need this variant of inject, simple inject('/')
|
@climba03003 PTAL |
