Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forceESM for vitest #274

Merged
merged 3 commits into from
Oct 13, 2022
Merged

forceESM for vitest #274

merged 3 commits into from
Oct 13, 2022

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Oct 12, 2022

Alternative for #273

@climba03003

Checklist

@Uzlopak Uzlopak mentioned this pull request Oct 12, 2022
Closed
2 tasks
climba03003
climba03003 approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one certainly better.

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Oct 12, 2022 •
edited

Tbh i personally dont understand why forcing esm avoids issues with typescript loading?! :D

I mean... how???

Edit: @climba03003 explained it.

@Uzlopak Uzlopak mentioned this pull request Oct 12, 2022
Closed
4 tasks
Uzlopak
Uzlopak commented Oct 12, 2022
View reviewed changes
vitest.config.ts Outdated Show resolved Hide resolved
@Uzlopak Uzlopak linked an issue Oct 12, 2022 that may be closed by this pull request
Typescript compiler error when running tests using Vitest #230
Closed
2 tasks
mcollina
mcollina approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak Uzlopak merged commit 860edaa into master Oct 13, 2022
@Uzlopak Uzlopak deleted the forceESM-for-vitest branch October 13, 2022 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@climba03003 climba03003 climba03003 approved these changes

@Eomm Eomm Awaiting requested review from Eomm

@jsumners jsumners Awaiting requested review from jsumners

@kibertoad kibertoad Awaiting requested review from kibertoad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript compiler error when running tests using Vitest
3 participants
@Uzlopak @mcollina @climba03003