The unit of maxAge is set in seconds, not msec

[seia-soto]

Prerequisites

• I have written a descriptive issue title
• I have searched existing issues to ensure the bug has not already been reported

Fastify version

4.7.0

Plugin version

8.3.0

Node.js version

v18.10.0

Operating system

macOS

Operating system version (i.e. 20.04, 11.3, 10)

12.6 (21G115)

Description

The following is fastify-cookie option typing (truncated). However, unlike the description of CookieSerializeOptions['maxAge'], the actual value takes second(s) as its unit.

export interface CookieSerializeOptions {
  /**  A `number` in milliseconds that specifies the `Expires` attribute by adding the specified milliseconds to the current date. If both `expires` and `maxAge` are set, then `expires` is used. */
  maxAge?: number;
}

Steps to Reproduce

I set the simple test environment: https://github.com/seia-soto/fastify-cookie-maxage

fastify.get('/set', async (_req, reply) => {
  reply.setCookie('test', '1', {
    maxAge: 3600
  })
})

Expected Behavior

If the unit is msec, we should see 3.6ss instead of a hour below: (LibreWolf)

This is not the browser specific issue: (Safari)

[seia-soto]

Using second for max-age is a common behavior in many other frameworks and I think we can just update the type definition instead of fixing this. We don't need to break any existing projects.

[Uzlopak]

It would be nice if you would provide a PR

[seia-soto]

Done 🙃