-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http2 vs http1 support seems backwards #7
Comments
It is the choice from
I believe is the complexity of directly write to |
Also we expect that fastify is behind a reverse proxy like Ingress/traefik which resolves a http2 request to http1.1 and vice versa. Maybe we can transplant http2 from nodejs sourcecode to our plugin? |
Yes, we can use |
I think we should just use the native functionality: https://nodejs.org/api/http2.html#responsewriteearlyhintslinks. |
We need to provide a compatible layer for And, if the native one is available, for example |
That's not necessarily true. A reverse proxy can still use http/2 to communicate to the backend services.
That would be a maintenance nightmare. |
Not really re-invented the wheel, |
My assessment:
I am wondering how we can test http2 because undici does not support http2 |
Use built-in |
created #8 for discussing http2 implementation |
Looks like the PR was closed without resolution :-( |
Since, |
ah, would be useful to document this somewhere. |
Prerequisites
Issue
So, in everything I've read, but most importantly, the Chrome docs, Early Hints are only supported on http2 and 3. But, this plugin throws an error if I try to set Fastify to use http2.
Is this not backwards? If correct as is, what's the reason we've disabled this on http/2? Thanks all!
The text was updated successfully, but these errors were encountered: