Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dev dependency typescript #261

Merged
merged 1 commit into from
Oct 6, 2022
Merged

remove dev dependency typescript #261

merged 1 commit into from
Oct 6, 2022

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Oct 4, 2022

Checklist

@Uzlopak Uzlopak requested a review from Fdawgs October 4, 2022 14:53
@Fdawgs
Copy link
Member

Fdawgs commented Oct 4, 2022

What's the Tsconfig file used for in this repo? Is that also worth removing?

mcollina
mcollina approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 47c5fdc into master Oct 6, 2022
@mcollina mcollina deleted the remove-typescript branch October 6, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@Fdawgs Fdawgs Awaiting requested review from Fdawgs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Uzlopak @Fdawgs @mcollina