Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add onlyCookie verify option tests and types #266

Merged
merged 5 commits into from
Nov 12, 2022
Merged

Add onlyCookie verify option tests and types #266

merged 5 commits into from
Nov 12, 2022

Conversation

ziimakc
Copy link
Contributor

@ziimakc ziimakc commented Nov 9, 2022 •
edited

Fork of #263 with added type test

Closes #263 and #260

Checklist

mage1k99 and others added 5 commits November 10, 2022 00:45
@mage1k99 @ziimakc
updated types for VerifyOptions
66c6d09 
- added `onlyCookie`
- updated namespaces on the `fastify.jwt` object

credits goes to @greebowarrior
@mage1k99 @ziimakc
added unit tests
23261ee 
check if `onlyCookie` property works well with fastify

Ref: #260
@mage1k99 @ziimakc
fix linter issue
6b310e1
@mage1k99 @ziimakc
remove unwanted namespace
a8c02f4
@ziimakc
test: add onlyCookie option to type tests
ebfe321
mcollina
mcollina approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eomm Eomm merged commit 56979d8 into fastify:master Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@Eomm Eomm Eomm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ziimakc @mcollina @Eomm @mage1k99