Multipart: Boundary not found

[tc-root-user]

Prerequisites

• I have written a descriptive issue title
• I have searched existing issues to ensure the bug has not already been reported

Fastify version

3.24.1

Plugin version

5.2.0

Node.js version

16.5.0

Operating system

Linux

Operating system version (i.e. 20.04, 11.3, 10)

Ubuntu 20.04

Description

When the file limit size is set, then headers are a mandatory prop. The code should be something like:

await req.file({
    headers: { "content-type": "multipart/form-data" },
    limits: {
        fileSize: (1024 * 1024) * 55
    }
})

The issue begins with passing those content-type at the request (as they are mandatory now), then the server responds with error 500 and the message "Multipart: Boundary not found".

Steps to Reproduce

1 - Make a file upload;
2 - Set some limit to the upload throught req.file(PROPS);
3 - Verify that the headers are mandatory now;
4 - Pass the respective header throught request;
5 - Try to do the upload;
6 - Observe that the server responds with error 500 with the message "Multipart: Boundary not found".

Expected Behavior

The upload happens normally respecting the file size limit.

[kibertoad]

@Uzlopak

[climba03003]

The main problem is the user must not pass the headers to option.

fastify-multipart/index.js

Line 321 in 0e449a7

{ headers: Object.assign({}, request.headers) },

The headers should be passed using request.headers. and it is handled by this plugin already.

My command here is correct, it is a breaking change if you force the user to pass the headers.
#300 (comment)

[kibertoad]

I'll produce a fix shortly.

[kibertoad]

@tc-root-user Can you please check with 5.2.1 (with removed explicit header)?`

[tc-root-user]

@tc-root-user Can you please check with 5.2.1 (with removed explicit header)?`

Working as expected!