Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the onBanReach Function #251

Merged
merged 13 commits into from
Jul 21, 2022
Merged

Added the onBanReach Function #251

merged 13 commits into from
Jul 21, 2022

Conversation

DiogoMarques2003
Copy link
Contributor

Checklist

@DiogoMarques2003
Copy link
Contributor Author

Can anyone check why the tests don't pass ?
In my pc is working ...

image

@DiogoMarques2003 DiogoMarques2003 mentioned this pull request Jul 20, 2022
Closed
2 tasks
@Eomm
Copy link
Member

Eomm commented Jul 20, 2022

You can check it here: https://github.com/fastify/fastify-rate-limit/runs/7425780475?check_suite_focus=true

spoiler: run npm run lint:fix and it should fix the issue

@Eomm Eomm linked an issue Jul 20, 2022 that may be closed by this pull request
would it be possible to add a function for when the number of requests for ban was reached, it would be executed #250
Closed
2 tasks
@DiogoMarques2003
Copy link
Contributor Author

@Eomm done

mcollina
mcollina approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eomm Eomm merged commit 53f51e2 into fastify:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@Eomm Eomm Eomm approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@DiogoMarques2003 @Eomm @mcollina @RafaelGSS