Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky redis unit tests #261

Merged
merged 3 commits into from
Sep 14, 2022
Merged

test: fix flaky redis unit tests #261

merged 3 commits into from
Sep 14, 2022

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Sep 14, 2022

We were running the unit tests in a very flaky way. Instead of actually waiting the redis flushall command we were having a noop callback. So it could happen, that flushall was not done and we were already running the next test.

This PR fixes that by implementing a teardown for those redis tests and fixing the corresponding assertions.

Checklist

@Uzlopak Uzlopak requested a review from Eomm September 14, 2022 07:49
@Uzlopak Uzlopak changed the title fix flaky tests fix flaky redis unit tests Sep 14, 2022
@Uzlopak Uzlopak requested a review from Fdawgs September 14, 2022 07:55
@Fdawgs Fdawgs changed the title fix flaky redis unit tests test: fix flakey redis unit tests Sep 14, 2022
@Uzlopak Uzlopak mentioned this pull request Sep 14, 2022
4 tasks
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let wait one more people before merging.

@Uzlopak Uzlopak changed the title test: fix flakey redis unit tests test: fix flaky redis unit tests Sep 14, 2022
@Fdawgs Fdawgs requested a review from Eomm September 14, 2022 10:08
@Eomm Eomm merged commit 76294c9 into master Sep 14, 2022
@Eomm Eomm deleted the fix-flaky-tests branch September 14, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants