Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps-dev): remove @types/ioredis #263

Merged
merged 1 commit into from
Sep 14, 2022
Merged

build(deps-dev): remove @types/ioredis #263

merged 1 commit into from
Sep 14, 2022

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Sep 14, 2022 •
edited

Checklist

@Fdawgs Fdawgs changed the title remove devDependency @types/ioredis build(deps-dev): remove @types/ioredis Sep 14, 2022
@Fdawgs
Copy link
Member

Fdawgs commented Sep 14, 2022

This not used with ioredis?

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Sep 14, 2022

ioredis 5 supplies its own types

https://github.com/luin/ioredis/blob/308017a6b9429c16b074e03e70f5524499476fa9/package.json#L6

@Fdawgs Fdawgs merged commit 2ea165e into master Sep 14, 2022
@Fdawgs Fdawgs deleted the remove-ioredis-types branch September 14, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fdawgs Fdawgs Fdawgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Uzlopak @Fdawgs