AddHook | Error - Async function has too many arguments

[ASR4]

My Fastify server code was working fine till last week. Now all of a sudden (I am sure some dependency somewhere got updated) I am getting errors on line where I am calling .addHook. I tried searching for similar issues but nothing helped. Error:

This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
Error: Async function has too many arguments. Async hooks should not use the 'done' argument.
    at Object.addHook (/app/node_modules/.pnpm/fastify@4.6.0/node_modules/fastify/fastify.js:573:15)
    at userRoutes (/app/packages/apps/server/src/routes/user/index.ts:55:10)
    at Plugin.exec (/app/node_modules/.pnpm/avvio@8.2.0/node_modules/avvio/plugin.js:130:19)
    at Boot.loadPlugin (/app/node_modules/.pnpm/avvio@8.2.0/node_modules/avvio/plugin.js:272:10)
    at processTicksAndRejections (node:internal/process/task_queues:82:21)

routes/user/index.js

...imports

export async function userRoutes(server: FastifyInstance) {
  // get user by email or id
  server.get(
    '/',
    {
      schema: {
        querystring: {
          email: { type: 'string' },
          id: { type: 'string' }
        },
        response: {
          200: $ref('responseUserSchema')
        }
      }
    },
    fetchUserHandler
  );

  server.addHook('preValidation', checkIfAuthenticated); // erroring here
}

export async function userAdminRoutes(server: FastifyInstance) {
  // add user
  server.post(
    '/',
    {
      schema: {
        body: $ref('createUserSchema'),
        response: {
          201: $ref('responseUserSchema')
        }
      }
    },
    createUserHandler
  );
  
   server.addHook('preValidation', checkIfAuthenticated); // erroring here
   server.addHook('preHandler', checkIfAdmin); //erroring here
}

checkIfAuthenticated

export const checkIfAuthenticated = async (
  req: FastifyRequest,
  res: FastifyReply,
  next
) => {
  try {
    const authToken = getAuthToken(req);
    const userInfo = await admin.auth().verifyIdToken(authToken as string);
    if (!userInfo) {
      throw new Error('User invalid');
    }
    logger.info('UserInfo successfully validated');
    req.headers.email = userInfo.email;
    //next();
  } catch (e) {
    logger.info('UserInfo is invalid');
    res
      .status(401)
      .send({ error: 'You are not authorized to make this request' });
  }
};

Essentially it's erroring here server.addHook('preValidation', checkIfAuthenticated); in userRoutes(). If this gets fixed it will complain about .addHook in userAdminRoutes.

Any idea how I can resolve this and why this started erroring out only recently?

Node: 16.15.0
Fastify: ^4.6.0

[mcollina]

This is correct. You are using an async function, you should not be accepting the next parameter.