Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes crash when using a non-standard error code #2184

Conversation

leorossi
Copy link
Contributor

@leorossi leorossi commented Apr 7, 2020

Updates how we validate reply status code.
Now allowing only numbers in range between 100 and 600

Fixes: #2169

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

Updates how we validate reply status code.
Now allowing only numbers in range between 100 and 600
lib/reply.js Outdated Show resolved Hide resolved
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Issue or PR that should land as semver patch v2.x Issue or pr related to Fastify v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fastify crashes when reply code is not recognized
3 participants