Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecosystem plugins integration testing #3342

Open
2 tasks done
zekth opened this issue Sep 26, 2021 · 5 comments
Open
2 tasks done

Ecosystem plugins integration testing #3342

zekth opened this issue Sep 26, 2021 · 5 comments
Labels
feature request New feature to be added

Comments

@zekth
Copy link
Member

zekth commented Sep 26, 2021

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the feature has not already been requested

馃殌 Feature Proposal

With the same approach as https://github.com/fastify/fastify/blob/main/.github/workflows/benchmark.yml , adding integration testing on PRs to ensure it does not break anything.

Using labels in the first step as we don't want to add it in the CI of the PRs.

This would basically add tests using the latest published version of the packages with minimum assertions.

Motivation

Not breaking the use of the ecosystem plugins.

avoiding issues like:

Example

No response

@zekth zekth added the feature request New feature to be added label Sep 26, 2021
@zekth zekth changed the title Ecosystem plugin integration testing Ecosystem plugins integration testing Sep 26, 2021
@mcollina
Copy link
Member

My colleague @dominykas worked on this problem for quite a while:

The goal would be to use wiby.

@dominykas
Copy link

馃憢 ohai!

I'm happy to chat about this or give some demos or help set this up - the documentation is quite lacking there (and it does require some setup which does not have any automation right now).

I gave a quick demo some 6 months ago of the current state: https://www.youtube.com/watch?v=m4SMPUshtzY - happy to give it again! I'm also somewhat available on the Node.js and OpenJS Foundation slacks if you want to ping me for a live discussion.

@Eomm
Copy link
Member

Eomm commented Sep 26, 2021

We have this repo to revamp
https://github.com/fastify/fastify-citgm

@mcollina
Copy link
Member

We have this repo to revamp

https://github.com/fastify/fastify-citgm

That repo is far from being great unfortunately, it's very hacky and ad-hoc that we have used when doing semver-major releases.

@zekth
Copy link
Member Author

zekth commented Sep 26, 2021

After checking the video of @dominykas it explains way better what we can achieve. Using label triggers it would make less noise with all the PR we can have, also easier for prototyping the integration. One thing is we would also want to implement the cleaning process.

I'm definitely interested in working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature to be added
Projects
None yet
Development

No branches or pull requests

4 participants