We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
content-type
3.27.4
No response
17.7.2
macOS
12.2
In the example here, fastify strips ; version=2 (and appends ; charset=utf-8) when reply.send() is called.
; version=2
; charset=utf-8
reply.send()
Bad:
reply.header( 'Content-Type', `application/vnd.example.com+json; version=2`, ); reply.send({ foo: 'bar' }); fastify.log.info(reply.getHeaders()); // content-type: application/vnd.example.com+json; charset=utf-8
Good:
reply.header( 'Content-Type', `application/vnd.example.com+json; version=2; charset=utf-8`, ); reply.send({ foo: 'bar' }); fastify.log.info(reply.getHeaders()); // content-type: application/vnd.example.com+json; version=2; charset=utf-8
The existing suffix should not be stripped and ; charset=utf-8 should be appended after.
The text was updated successfully, but these errors were encountered:
Seems like this pr #2315 has a problem, I will take a look
Sorry, something went wrong.
fix: bug fix fastify#3788
80f1eea
fix: set reply's default charset to utf8 (#3789)
78e9ddb
* fix: bug fix #3788 * test: delete unref, use teardown instead
Wow! Thanks for the fast turnaround!
Successfully merging a pull request may close this issue.
Prerequisites
Fastify version
3.27.4
Plugin version
No response
Node.js version
17.7.2
Operating system
macOS
Operating system version (i.e. 20.04, 11.3, 10)
12.2
Description
In the example here, fastify strips
; version=2
(and appends; charset=utf-8
) whenreply.send()
is called.Steps to Reproduce
Bad:
Good:
Expected Behavior
The existing suffix should not be stripped and
; charset=utf-8
should be appended after.The text was updated successfully, but these errors were encountered: