Support send TypedArray objects

[suerta-git]

Prerequisites

• I have written a descriptive issue title
• I have searched existing issues to ensure the feature has not already been requested

🚀 Feature Proposal

AFAIK, currently only node.js Buffer objects are accepted to be sent by reply.send() method for buffer-like data.

However, as a part of ECMAScript standard, TypedArray and its subclasses are also commonly used, because they are well supported by both of browser and node. So support them is obviously necessary.

Motivation

No response

Example

No response

[jsumners]

What are you expecting to happen? Buffers are sent as an octet stream:

fastify/lib/reply.js

Lines 151 to 157 in 7431a23

	if (Buffer.isBuffer(payload)) {
	if (hasContentType === false) {
	this[kReplyHeaders]['content-type'] = CONTENT_TYPE.OCTET
	}
	onSendHook(this, payload)
	return this
	}

A TypedArray could be sent in the same way, but the receiving client would not be receiving an instance of TypedArray.

[suerta-git]

Sorry @jsumners, I don't understand what the conflict is between octet-stream and TypedArray.

In my mind, Buffers and TypedArrays are just different ways under different environments to manipulate binary data. Both of them can do the same thing on any piece of binary data.
As for octet-stream, it is just a content type hint that indicates the response data is binary, not related to any specific type or class.

[jsumners]

I didn't say there is a conflict. I asked what you expect to happen when reply.send(aTypedArry) is performed.

[suerta-git]

Ok, I misunderstood.

I asked what you expect to happen when reply.send(aTypedArry) is performed.

As same as buffers I think. Send bytes to client.

[jsumners]

Then I have already highlighted where a change needs to be made, and what needs to be done. A PR would be welcome.

[Eomm]

Totally agree!

The new aws@3 client use them a lot!

[voxpelli]

Fixed by #4735, right?

[metcoder95]

Done by #4735