Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI failure with v18.19.0 #5198

Closed
jsumners opened this issue Dec 8, 2023 · 6 comments · Fixed by #5195
Closed

CI failure with v18.19.0 #5198

jsumners opened this issue Dec 8, 2023 · 6 comments · Fixed by #5195

Comments

@jsumners
Copy link
Member

jsumners commented Dec 8, 2023

#5195 shows that our CI fails with Node.js v18.19.0. I can confirm this locally. I am seeing issues with v18.19.0 in another project and found the commit breaking that project to be nodejs/node@bac9b17. However, a build of Node with that commit passes the Fastify CI. So our issue here is somewhere between that commit and the v18.19.0 tag.
@jsumners
Copy link
Member Author

jsumners commented Dec 9, 2023

The commit that triggers our CI failure is nodejs/node@2969722.

@Uzlopak
Copy link
Contributor

Uzlopak commented Dec 9, 2023

So closeIdleConnections was backported?

@jsumners
Copy link
Member Author

jsumners commented Dec 9, 2023

Looks that way.

@jsumners
Copy link
Member Author

jsumners commented Dec 9, 2023

There was discussion at the end of nodejs/node#48383 about it breaking core's CITGM within Fastify.

@Uzlopak Uzlopak linked a pull request Dec 10, 2023 that will close this issue
ci: fix broken ci by skipping tests if node v > 18.19.0 #5195
Merged
4 tasks
@Uzlopak
Copy link
Contributor

Uzlopak commented Dec 10, 2023

Reopened #5195

@mcollina
Copy link
Member

My bad, I didn't notice this was actually backported to node v18, the last few months have been hectic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: fix broken ci by skipping tests if node v > 18.19.0 fastify/fastify
3 participants
@mcollina @jsumners @Uzlopak