Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cant we make this an options to be passed for useSemicolonDefault to find-my-way? #5237

Closed
mcollina opened this issue Dec 26, 2023 · 4 comments · Fixed by #5239
Closed

Cant we make this an options to be passed for useSemicolonDefault to find-my-way? #5237

mcollina opened this issue Dec 26, 2023 · 4 comments · Fixed by #5239
Labels
good first issue Good for newcomers

Comments

@mcollina
Copy link
Member

Cant we make this an options to be passed?
Solve it maybe like this?

  options.config.useSemicolonDelimiter ?= true // To avoid a breaking change
  • typescript typings and documentation?

Originally posted by @Uzlopak in #5236 (comment)

@mcollina mcollina added the good first issue Good for newcomers label Dec 26, 2023
@Fdawgs
Copy link
Member

Fdawgs commented Dec 26, 2023

Can we roll this into v5 as a breaking change and keep it disabled and non-configurable?

From reading the spec linked in the original issue it's going against the standard so I don't think we should be encouraging it?

@Uzlopak
Copy link
Contributor

Uzlopak commented Dec 26, 2023

I am a configuration fetishist. :)

But i dont have a strong opinion on this.

@gurgunday
Copy link
Member

Can we roll this into v5 as a breaking change and keep it disabled and non-configurable?

From reading the spec linked in the original issue it's going against the standard so I don't think we should be encouraging it?

+1

@mcollina
Copy link
Member Author

We should add an option right now, and flip the default in v5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants