Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into next #5421

Closed
2 tasks done
gurgunday opened this issue Apr 22, 2024 · 4 comments
Closed
2 tasks done

Merge main into next #5421

gurgunday opened this issue Apr 22, 2024 · 4 comments

Comments

@gurgunday
Copy link
Member

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the issue has not already been raised

Issue

  • The difference between the branches is growing larger and larger, it already requires a careful rebase/merge — there are conflicts
  • I don't have access and even if I did, I don't know if pushing directly is the right way to do it

Cc @climba03003 since you've done this a few times I believe 🤠

@climba03003
Copy link
Member

The difference between the branches is growing larger and larger

Not that large than I thought.

it already requires a careful rebase/merge — there are conflicts

Conflict always there if you are working on two branch, you may also see the same when backporting.

I don't have access and even if I did, I don't know if pushing directly is the right way to do it

For me, what it does is the same as sending PR. Reviewing the merge conflict or that large amount of commits is not feasible.
We may try to do in PR approach, but I assume it unlikely be reviewed. Or it may just be direct merge when unit test pass.

@gurgunday
Copy link
Member Author

Okay I agree that direct merge is easier, can you do it today?

Because I want to merge #5419 but if we do it before rebaseing/merging from main, the conflicts will increase

Would you want to do it after or before #5419?

@climba03003
Copy link
Member

can you do it today?

It's already synced. before I comment.

@gurgunday
Copy link
Member Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants