Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fastify-appwrite plugin #3259

Merged
merged 1 commit into from Aug 15, 2021
Merged

Add fastify-appwrite plugin #3259

merged 1 commit into from Aug 15, 2021

Conversation

maniecodes
Copy link
Contributor

@maniecodes maniecodes commented Aug 14, 2021 •
edited

A fastify plugin for interacting with Appwrite backend server

@github-actions github-actions bot added documentation Improvements or additions to documentation plugin Identify a pr to the doc that adds a plugin. labels Aug 14, 2021
RafaelGSS
RafaelGSS approved these changes Aug 15, 2021
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mcollina
Copy link
Member

For compatibility with other plugins and apps, I would recommend to wrap all the decorated services into a single property. They should be accessed via fastify.appwrite.user or similar.

@maniecodes
Copy link
Contributor Author

For compatibility with other plugins and apps, I would recommend to wrap all the decorated services into a single property. They should be accessed via fastify.appwrite.user or similar.

I agree with you @mcollina. I will make the necessary changes.

@maniecodes
Copy link
Contributor Author

@RafaelGSS @mcollina I have made the necessary changes.

RafaelGSS
RafaelGSS approved these changes Aug 15, 2021
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mcollina mcollina merged commit e0541c7 into fastify:main Aug 15, 2021
@mcollina
Copy link
Member

Thanks! Great to see!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation plugin Identify a pr to the doc that adds a plugin.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maniecodes @mcollina @RafaelGSS