Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: automerge only minor semver #3264

Merged
merged 1 commit into from Aug 17, 2021
Merged

ci: automerge only minor semver #3264

merged 1 commit into from Aug 17, 2021

Conversation

Eomm
Copy link
Member

@Eomm Eomm commented Aug 17, 2021

We should not merge major into the project if the ci is green because a module may drop a Node.js supported by fastify

examples:
#3263
fastify/light-my-request#132

Checklist

@Eomm Eomm added the chore Small changes or internal project maintenance label Aug 17, 2021
@Eomm Eomm self-assigned this Aug 17, 2021
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mcollina mcollina merged commit e3903cf into main Aug 17, 2021
@mcollina mcollina deleted the Eomm-patch-2 branch August 17, 2021 17:14
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
chore Small changes or internal project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants