Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error messages #3277

Merged
merged 1 commit into from Aug 23, 2021
Merged

fix error messages #3277

merged 1 commit into from Aug 23, 2021

Conversation

matthyk
Copy link
Contributor

@matthyk matthyk commented Aug 22, 2021

Fixes a bug where incorrect error messages were produced when using the path option instead of the url option for the route declaration with routemethod.

So

fastify.route({
      method: 'GET',
      path: '/test'
    })

would produce the error message: Missing handler function for GET:undefined route.

Checklist

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mcollina mcollina merged commit b213983 into fastify:main Aug 23, 2021
@Eomm Eomm added the bugfix Issue or PR that should land as semver patch label Aug 23, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Issue or PR that should land as semver patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants