Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed unresponsive server #3283 #3285

Merged
merged 4 commits into from Sep 4, 2021
Merged

fixed unresponsive server #3283 #3285

merged 4 commits into from Sep 4, 2021

Conversation

Krishanu230
Copy link
Contributor

Checklist

@Eomm
Copy link
Member

Eomm commented Aug 31, 2021

Could you add a test for this bugfix?

mcollina
mcollina requested changes Aug 31, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a unit test?

Eomm
Eomm reviewed Sep 3, 2021
View reviewed changes
test/reply-error.test.js Outdated Show resolved Hide resolved
test/reply-error.test.js Outdated Show resolved Hide resolved
Krishanu230 and others added 2 commits September 5, 2021 01:38
@Krishanu230 @Eomm
Update test/reply-error.test.js
d6bb67b 
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
@Krishanu230 @Eomm
Update test cases test/reply-error.test.js
56b6262 
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
mcollina
mcollina approved these changes Sep 4, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit e0ca9c4 into fastify:main Sep 4, 2021
@jsumners jsumners mentioned this pull request Sep 12, 2021
Closed
sergejostir added a commit to sergejostir/fastify that referenced this pull request Nov 14, 2021
@sergejostir
fixup! fixed unresponsive server fastify#3283 (fastify#3285)
8abb0cd
sergejostir added a commit to sergejostir/fastify that referenced this pull request Nov 14, 2021
@sergejostir
fixup! fixed unresponsive server fastify#3283 (fastify#3285)
94e21aa
@sergejostir sergejostir mentioned this pull request Nov 14, 2021
Merged
4 tasks
mcollina pushed a commit that referenced this pull request Nov 23, 2021
@sergejostir
Adjust existing PRs for the new reply.sent handing (#3444)
fd8503a 
* fixup! Encapsulated error handling (#3261)

* fixup! fixed unresponsive server  #3283 (#3285)

* fixup! fix: reply object not marked as sent for stream payloads (#3318)
@github-actions
Copy link

github-actions bot commented Sep 6, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@climba03003 climba03003 climba03003 left review comments

@mcollina mcollina mcollina approved these changes

@Eomm Eomm Eomm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Krishanu230 @Eomm @mcollina @climba03003