Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new repo fastify/demo #1001

Open
jean-michelet opened this issue Feb 27, 2024 · 8 comments
Open

Create a new repo fastify/demo #1001

jean-michelet opened this issue Feb 27, 2024 · 8 comments
Labels
help wanted Extra attention is needed

Comments

@jean-michelet
Copy link

When I was in the PHP ecosystem, I worked with the Symfony framework. They have created a symfony/demo repo using what they consider best practices. I found the perspective of reading the code of a web project considered optimal by the core team very useful and reassuring.

Do you think it's worth it?
If so, I'm fully committed to work on it.

I'm not sure what the theme should be, though. It seems that the main type of development in the Node ecosystem are apis.

@jean-michelet jean-michelet added the help wanted Extra attention is needed label Feb 27, 2024
@jean-michelet jean-michelet changed the title Create a new repo fastify/demo to learn by looking at a concret project Create a new repo fastify/demo Feb 27, 2024
@Uzlopak
Copy link

Uzlopak commented Feb 27, 2024

Imho

It is already too much work to maintain the core plugins. I have the feeling that few core deps need more love but we have currently no time.

It would be cooler if you first help with the other plugins before we open a demo repo.

If the core plugins are all green, a demo repo on top would be no Problem.

@jean-michelet
Copy link
Author

If the core plugins are all green, a demo repo on top would be no Problem.

You mean code coverage?

@metcoder95
Copy link
Member

Do you have a concrete example you are willing to share or would you like to start one?
Maybe we can start from there, have a look and decide further steps

@jean-michelet
Copy link
Author

jean-michelet commented Feb 27, 2024

Do you have a concrete example you are willing to share or would you like to start one?

I'd like to start a clean repo, following carefully the doc and trying to find interesting uses cases. Something basic at first, in order to gather your feedbacks and plan what to do next.

But I'd like to know if you're interested before jumping in.

@jean-michelet
Copy link
Author

Sorry @Uzlopak, I recently worked on an issue to increase test coverage on find-my-way and so I understood "all green" = 100% test coverage. I guess you meant I should help you with the issues on core plugins, right?

@metcoder95
Copy link
Member

I believe any contribution can be of value, and this seems to provide good basics to start with fastify as framework; happy on my side to support you by giving a look at it 🙂

@jean-michelet
Copy link
Author

Thanks for the proposal @metcoder95,

It's not urgent so I can gradually work on this demo and looking at ongoing issues to help you with core plugins.

@mcollina, are you open to the idea of an official demo repo on your side?

@melroy89
Copy link
Contributor

melroy89 commented Mar 15, 2024

+3 I would like seeing such an official demo repo using several plugins like maybe autoload, cors, env, helmet, mysql and swagger. With some routes, controllers, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants