Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createSecretKey and hmac (e.g. in fastify/cookie) #968

Open
Uzlopak opened this issue Nov 30, 2023 · 1 comment
Open

createSecretKey and hmac (e.g. in fastify/cookie) #968

Uzlopak opened this issue Nov 30, 2023 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@Uzlopak
Copy link

Uzlopak commented Nov 30, 2023 •
edited

I wanted to have an open discussion regarding the use of secret keys in hmac.

I think we can have performance improvements by using createSecretKey. Atleast it seems that the heap usage could be reduced.

We should consider investigating this?!

I am opening this issue to not forget about it. It is 2 o clock in the morning and I saw this potential perf improvement while checking the performance of a different product. Good night.

@kibertoad
@Fdawgs
@Eomm
@gurgunday
@mcollina
@Uzlopak Uzlopak added the help wanted Extra attention is needed label Nov 30, 2023
@mcollina
Copy link
Member

secret keys... for what? Do we have an hot path where we create a lot of keys?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcollina @Uzlopak