-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include response time in "request completed" log #11
Comments
You need to use some fake timers for it such as What about this format instead?
|
@TommyDew42 |
The initial idea (fastify/fastify#4027) was simple and just to provide a better looking log to developers. I guess it's alright to add the response time if users find it useful? @mcollina |
The timing information is easily adjusted by the user: |
The standard response log has that info already |
Prerequisites
馃殌 Feature Proposal
Hi! I think it will be better if the completed request log also included the original response time. Maybe something like this
2017-02-14 20:51:48.000+0800 - info - completed in 0.14731597900390625 seconds - request completed
I've been trying to implement this simple feature by myself, but I am not sure how to write test for this response time? Any recommendations maybe, so that I can open PR for this issue.
Thanks
Motivation
No response
Example
No response
The text was updated successfully, but these errors were encountered: