Add support for layout in handlebars #136
Conversation
index.js
Outdated
|
|
||
| if (layoutFileName) { | ||
| try { | ||
| readFileSync(join(templatesDir, getPage(layoutFileName, 'hbs'))) |
There was a problem hiding this comment.
Is this just a check on access?
There was a problem hiding this comment.
Yes. If an user passes a layout but the layout is not readable, this would return an error to them.
There was a problem hiding this comment.
Would you mind using https://nodejs.org/api/fs.html#fs_fs_accesssync_path_mode instead?
| @@ -398,6 +409,30 @@ function fastifyView (fastify, opts, next) { | |||
| } else { | |||
| next() | |||
| } | |||
|
|
|||
| function withLayout (render) { | |||
| if (layoutFileName) { | |||
There was a problem hiding this comment.
How is this option going to affect other engines?
There was a problem hiding this comment.
Currently it would only affect handlebars. This is because some engines already support their own layouts (e.g: pug).
It is also possible to add support to other engines that don't already support layouts by applying them the withLayout decorator (see here)
There was a problem hiding this comment.
would you mind throwing if layout is present and the engine is not 'handlebars'?
There was a problem hiding this comment.
No problem. Please see my new commits.
…ngine other than handlebars
|
@smartiniOnGitHub would you mind to take a look? |
|
@mcollina sure, I'll provide a feedbask ASAP |
No problem |
Relates to #112
A few notes regarding this PR:
layoutsupport. I'm not sure what are the views on functional programming for this project, so please let me know if you'd prefer a different implementation.Checklist
npm run testandnpm run benchmark