Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom Content-Type header for Nunjucks #354

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Allow custom Content-Type header for Nunjucks #354

merged 1 commit into from
Nov 22, 2022

Conversation

smigles
Copy link
Contributor

@smigles smigles commented Nov 21, 2022

It allows custom Content-Type response header for Nunjucks template engine.

Closes #353

Checklist

@Uzlopak
Copy link
Contributor

Uzlopak commented Nov 22, 2022

Does it only affect nunjucks or all engines?

@smigles
Copy link
Contributor Author

smigles commented Nov 22, 2022

@Uzlopak, Nunjucks only. As far as I can tell, also you cannot set custom Content-Type for Eta. For other engines you can.

Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that on my mobile phone and did not see that only the nunjucks code was effected.

LGTM

@Uzlopak Uzlopak merged commit 4c592a4 into fastify:master Nov 22, 2022
@treeder
Copy link

treeder commented Dec 30, 2022

Same issue with eta as @smigles said.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow custom Content-Type header for Nunjucks
4 participants