Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload fails with "no implicit conversion of true into String" #19659

Closed
cherpake opened this issue Nov 29, 2021 · 29 comments
Closed

Upload fails with "no implicit conversion of true into String" #19659

cherpake opened this issue Nov 29, 2021 · 29 comments

Comments

@cherpake
Copy link
Contributor

cherpake commented Nov 29, 2021

/usr/local/Cellar/fastlane/2.198.1/libexec/gems/fastlane-2.198.1/fastlane_core/lib/fastlane_core/itunes_transporter.rb:504:in `basename': \e[31m[!] no implicit conversion of true into String\e[0m (TypeError)
	from /usr/local/Cellar/fastlane/2.198.1/libexec/gems/fastlane-2.198.1/fastlane_core/lib/fastlane_core/itunes_transporter.rb:504:in `upload'
	from /usr/local/Cellar/fastlane/2.198.1/libexec/gems/fastlane-2.198.1/deliver/lib/deliver/runner.rb:189:in `upload_binary'
	from /usr/local/Cellar/fastlane/2.198.1/libexec/gems/fastlane-2.198.1/deliver/lib/deliver/runner.rb:59:in `run'
	from /usr/local/Cellar/fastlane/2.198.1/libexec/gems/fastlane-2.198.1/deliver/lib/deliver/commands_generator.rb:82:in `block (2 levels) in run'
	from /usr/local/Cellar/fastlane/2.198.1/libexec/gems/commander-4.6.0/lib/commander/command.rb:187:in `call'
	from /usr/local/Cellar/fastlane/2.198.1/libexec/gems/commander-4.6.0/lib/commander/command.rb:157:in `run'
	from /usr/local/Cellar/fastlane/2.198.1/libexec/gems/commander-4.6.0/lib/commander/runner.rb:444:in `run_active_command'
	from /usr/local/Cellar/fastlane/2.198.1/libexec/gems/fastlane-2.198.1/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:117:in `run!'
	from /usr/local/Cellar/fastlane/2.198.1/libexec/gems/commander-4.6.0/lib/commander/delegates.rb:18:in `run!'
	from /usr/local/Cellar/fastlane/2.198.1/libexec/gems/fastlane-2.198.1/deliver/lib/deliver/commands_generator.rb:187:in `run'
	from /usr/local/Cellar/fastlane/2.198.1/libexec/gems/fastlane-2.198.1/deliver/lib/deliver/commands_generator.rb:18:in `start'
	from /usr/local/Cellar/fastlane/2.198.1/libexec/gems/fastlane-2.198.1/fastlane/lib/fastlane/cli_tools_distributor.rb:114:in `take_off'
	from /usr/local/Cellar/fastlane/2.198.1/libexec/gems/fastlane-2.198.1/bin/fastlane:23:in `<top (required)>'
	from /usr/local/Cellar/fastlane/2.198.1/libexec/bin/fastlane:23:in `load'
	from /usr/local/Cellar/fastlane/2.198.1/libexec/bin/fastlane:23:in `<main>'
/usr/local/Cellar/fastlane/2.198.1/libexec/gems/fastlane-2.198.1/fastlane_core/lib/fastlane_core/itunes_transporter.rb:504:in `basename': no implicit conversion of true into String (TypeError)
	from /usr/local/Cellar/fastlane/2.198.1/libexec/gems/fastlane-2.198.1/fastlane_core/lib/fastlane_core/itunes_transporter.rb:504:in `upload'
	from /usr/local/Cellar/fastlane/2.198.1/libexec/gems/fastlane-2.198.1/deliver/lib/deliver/runner.rb:189:in `upload_binary'
	from /usr/local/Cellar/fastlane/2.198.1/libexec/gems/fastlane-2.198.1/deliver/lib/deliver/runner.rb:59:in `run'
	from /usr/local/Cellar/fastlane/2.198.1/libexec/gems/fastlane-2.198.1/deliver/lib/deliver/commands_generator.rb:82:in `block (2 levels) in run'
	from /usr/local/Cellar/fastlane/2.198.1/libexec/gems/commander-4.6.0/lib/commander/command.rb:187:in `call'
	from /usr/local/Cellar/fastlane/2.198.1/libexec/gems/commander-4.6.0/lib/commander/command.rb:157:in `run'
	from /usr/local/Cellar/fastlane/2.198.1/libexec/gems/commander-4.6.0/lib/commander/runner.rb:444:in `run_active_command'
	from /usr/local/Cellar/fastlane/2.198.1/libexec/gems/fastlane-2.198.1/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:117:in `run!'
	from /usr/local/Cellar/fastlane/2.198.1/libexec/gems/commander-4.6.0/lib/commander/delegates.rb:18:in `run!'
	from /usr/local/Cellar/fastlane/2.198.1/libexec/gems/fastlane-2.198.1/deliver/lib/deliver/commands_generator.rb:187:in `run'
	from /usr/local/Cellar/fastlane/2.198.1/libexec/gems/fastlane-2.198.1/deliver/lib/deliver/commands_generator.rb:18:in `start'
	from /usr/local/Cellar/fastlane/2.198.1/libexec/gems/fastlane-2.198.1/fastlane/lib/fastlane/cli_tools_distributor.rb:114:in `take_off'
	from /usr/local/Cellar/fastlane/2.198.1/libexec/gems/fastlane-2.198.1/bin/fastlane:23:in `<top (required)>'
	from /usr/local/Cellar/fastlane/2.198.1/libexec/bin/fastlane:23:in `load'
	from /usr/local/Cellar/fastlane/2.198.1/libexec/bin/fastlane:23:in `<main>'
@fastlane-bot
Copy link

It seems like you have not included the output of fastlane env
To make it easier for us help you resolve this issue, please update the issue to include the output of fastlane env 👍

@cherpake
Copy link
Contributor Author

cherpake commented Nov 29, 2021

✅ fastlane environment ✅

Stack

Key Value
OS 12.1
Ruby 3.0.2
Bundler? false
Git git version 2.32.0
Installation Source /usr/local/Cellar/fastlane/2.198.1/libexec/bin/fastlane
Host macOS 12.1 (21C5021h)
Ruby Lib Dir /usr/local/Cellar/ruby/3.0.2_1/lib
OpenSSL Version OpenSSL 1.1.1l 24 Aug 2021
Is contained false
Is homebrew true
Is installed via Fabric.app false
Xcode Path /Applications/Xcode.app/Contents/Developer/
Xcode Version 13.1
Swift Version 5.5.1

System Locale

Variable Value
LANG en_US.UTF-8
LC_ALL en_US.UTF-8
LANGUAGE

fastlane gems

Gem Version Update-Status
fastlane 2.198.1 ✅ Up-To-Date

Loaded fastlane plugins:

No plugins Loaded

Loaded gems
Gem Version
did_you_mean 1.5.0
atomos 0.1.3
rexml 3.2.5
CFPropertyList 3.0.5
claide 1.0.3
colored2 3.1.2
nanaimo 0.3.0
xcodeproj 1.21.0
rouge 2.0.7
xcpretty 0.3.0
terminal-notifier 2.0.0
unicode-display_width 1.8.0
terminal-table 1.8.0
plist 3.6.0
public_suffix 4.0.6
addressable 2.8.0
multipart-post 2.0.0
word_wrap 1.0.0
optparse 0.1.1
tty-screen 0.8.1
tty-cursor 0.7.1
tty-spinner 0.9.3
artifactory 3.0.15
babosa 1.0.4
colored 1.2
highline 2.0.3
commander 4.6.0
excon 0.88.0
faraday-em_http 1.0.0
faraday-em_synchrony 1.0.0
faraday-excon 1.1.0
faraday-httpclient 1.0.1
faraday-net_http 1.0.1
faraday-net_http_persistent 1.2.0
faraday-patron 1.0.0
faraday-rack 1.0.0
ruby2_keywords 0.0.5
faraday 1.8.0
unf_ext 0.0.8
unf 0.1.4
domain_name 0.5.20190701
http-cookie 1.0.4
faraday-cookie_jar 0.0.7
faraday_middleware 1.2.0
fastimage 2.2.5
gh_inspector 1.1.3
json 2.5.1
mini_magick 4.11.0
naturally 2.2.1
rubyzip 2.3.2
security 0.1.3
xcpretty-travis-formatter 1.0.1
dotenv 2.7.6
bundler 2.2.22
simctl 1.6.8
jwt 2.3.0
uber 0.1.0
declarative 0.0.20
trailblazer-option 0.1.2
representable 3.1.1
retriable 3.1.2
mini_mime 1.1.2
memoist 0.16.2
multi_json 1.15.0
os 1.1.4
signet 0.16.0
googleauth 1.1.0
httpclient 2.8.3
webrick 1.7.0
google-apis-core 0.4.1
google-apis-playcustomapp_v1 0.6.0
google-apis-androidpublisher_v3 0.13.0
google-cloud-env 1.5.0
google-cloud-errors 1.2.0
google-cloud-core 1.6.0
google-apis-iamcredentials_v1 0.8.0
google-apis-storage_v1 0.9.0
rake 13.0.6
digest-crc 0.6.4
google-cloud-storage 1.34.1
emoji_regex 3.2.3
jmespath 1.4.0
aws-partitions 1.532.0
aws-eventstream 1.2.0
aws-sigv4 1.4.0
aws-sdk-core 3.122.1
aws-sdk-kms 1.51.0
aws-sdk-s3 1.106.0
tsort 0.1.0
uri 0.10.1
set 1.0.1
forwardable 1.3.2
logger 1.4.3
pathname 0.1.0
shellwords 0.1.0
cgi 0.2.0
date 3.1.0
timeout 0.1.1
stringio 3.0.0
openssl 2.2.0
io-nonblock 0.1.0
ipaddr 1.2.2
io-wait 0.1.0
zlib 1.1.0
resolv 0.2.0
securerandom 0.1.0
digest 3.0.0
time 0.1.0
open-uri 0.1.0
mutex_m 0.1.1
net-protocol 0.1.0
ostruct 0.3.1
english 0.7.1
erb 2.2.0
strscan 3.0.0
abbrev 0.1.0
io-console 0.5.7
tempfile 0.1.1
delegate 0.2.0
fileutils 1.5.0
tmpdir 0.1.2
base64 0.1.0
singleton 0.1.1
net-http 0.1.1
open3 0.1.1
nkf 0.1.0
prettyprint 0.1.0
pp 0.1.0
find 0.1.0
yaml 0.1.1
psych 3.3.0

generated on: 2021-11-29

@Mariliee

This comment was marked as spam.

@c128128
Copy link

c128128 commented Dec 11, 2021

Any news on this issue ?

@GeylanKalafMohe
Copy link

Please fastlane team fix this issue for macos!

@GeylanKalafMohe
Copy link

This issue also happens with iOS!!

@blyscuit
Copy link

Facing this issue for 2 weeks now.

@jaspervp
Copy link

jaspervp commented Jan 3, 2022

I am having the same issue. It worked in 2.197.0, but is broken in 2.198.0 and higher.

@GeylanKalafMohe
Copy link

@jaspervp how to downgrade fastlane to that version?

@blyscuit
Copy link

blyscuit commented Jan 4, 2022

@jaspervp how to downgrade fastlane to that version?

@SwiftiSwift If you are using bundle to run fastlane. You can specify in Gemfile

# Gemfile
gem "fastlane", "~> 2.197.0"

If not, you will have to remove current fastlane and reinstall the specific version.

I am having the same issue. It worked in 2.197.0, but is broken in 2.198.0 and higher.

This works for me in 2.197.0 as well. Will not use higher version until it is fix. Thank you for the suggestion.

edit: tag user

@Erin69
Copy link

Erin69 commented Feb 1, 2022

@jaspervp how to downgrade fastlane to that version?

@SwiftiSwift If you are using bundle to run fastlane. You can specify in Gemfile

# Gemfile
gem "fastlane", "~> 2.197.0"

If not, you will have to remove current fastlane and reinstall the specific version.

I am having the same issue. It worked in 2.197.0, but is broken in 2.198.0 and higher.

This works for me in 2.197.0 as well. Will not use higher version until it is fix. Thank you for the suggestion.

edit: tag user

Thank you for the reply, I will try to figure it out for more.
Prepaid Gift Balance

@mezhevikin
Copy link

mezhevikin commented Feb 2, 2022

Have the same problem.

🚫 fastlane environment 🚫

Stack

Key Value
OS 11.5.2
Ruby 3.0.3
Bundler? false
Git git version 2.32.0 (Apple Git-132)
Installation Source /opt/homebrew/Cellar/fastlane/2.204.0/libexec/bin/fastlane
Host macOS 11.5.2 (20G95)
Ruby Lib Dir /opt/homebrew/Cellar/ruby/3.0.3/lib
OpenSSL Version OpenSSL 1.1.1l 24 Aug 2021
Is contained false
Is homebrew true
Is installed via Fabric.app false
Xcode Path /Applications/Xcode.app/Contents/Developer/
Xcode Version 13.2.1
Swift Version 5.5.2

System Locale

Error
No Locale with UTF8 found 🚫

fastlane files:

No Fastfile found

No Appfile found

fastlane gems

Gem Version Update-Status
fastlane 2.204.0 ✅ Up-To-Date

Loaded fastlane plugins:

No plugins Loaded

Loaded gems
Gem Version
did_you_mean 1.5.0
atomos 0.1.3
rexml 3.2.5
CFPropertyList 3.0.5
claide 1.1.0
colored2 3.1.2
nanaimo 0.3.0
xcodeproj 1.21.0
rouge 2.0.7
xcpretty 0.3.0
terminal-notifier 2.0.0
unicode-display_width 1.8.0
terminal-table 1.8.0
plist 3.6.0
public_suffix 4.0.6
addressable 2.8.0
multipart-post 2.0.0
word_wrap 1.0.0
optparse 0.1.1
tty-screen 0.8.1
tty-cursor 0.7.1
tty-spinner 0.9.3
artifactory 3.0.15
babosa 1.0.4
colored 1.2
highline 2.0.3
commander 4.6.0
excon 0.90.0
faraday-em_http 1.0.0
faraday-em_synchrony 1.0.0
faraday-excon 1.1.0
faraday-httpclient 1.0.1
faraday-multipart 1.0.3
faraday-net_http 1.0.1
faraday-net_http_persistent 1.2.0
faraday-patron 1.0.0
faraday-rack 1.0.0
faraday-retry 1.0.3
ruby2_keywords 0.0.5
faraday 1.9.3
unf_ext 0.0.8
unf 0.1.4
domain_name 0.5.20190701
http-cookie 1.0.4
faraday-cookie_jar 0.0.7
faraday_middleware 1.2.0
fastimage 2.2.6
gh_inspector 1.1.3
mini_magick 4.11.0
naturally 2.2.1
rubyzip 2.3.2
security 0.1.3
xcpretty-travis-formatter 1.0.1
dotenv 2.7.6
bundler 2.2.32
simctl 1.6.8
jwt 2.3.0
uber 0.1.0
declarative 0.0.20
trailblazer-option 0.1.2
representable 3.1.1
retriable 3.1.2
mini_mime 1.1.2
memoist 0.16.2
multi_json 1.15.0
os 1.1.4
signet 0.16.0
googleauth 1.1.0
httpclient 2.8.3
webrick 1.7.0
google-apis-core 0.4.2
google-apis-playcustomapp_v1 0.7.0
google-apis-androidpublisher_v3 0.16.0
google-cloud-env 1.5.0
google-cloud-errors 1.2.0
google-cloud-core 1.6.0
google-apis-iamcredentials_v1 0.10.0
google-apis-storage_v1 0.11.0
rake 13.0.6
digest-crc 0.6.4
google-cloud-storage 1.36.0
emoji_regex 3.2.3
jmespath 1.5.0
aws-partitions 1.551.0
aws-eventstream 1.2.0
aws-sigv4 1.4.0
aws-sdk-core 3.125.5
aws-sdk-kms 1.53.0
aws-sdk-s3 1.111.3
set 1.0.1
json 2.6.1
forwardable 1.3.2
logger 1.4.3
pathname 0.1.0
shellwords 0.1.0
cgi 0.2.1
date 3.1.3
timeout 0.1.1
stringio 3.0.1
securerandom 0.1.0
uri 0.10.1
ipaddr 1.2.2
openssl 2.2.1
digest 3.0.0
io-nonblock 0.1.0
io-wait 0.2.0
zlib 2.0.0
resolv 0.2.1
time 0.1.0
open-uri 0.1.0
mutex_m 0.1.1
net-protocol 0.1.1
ostruct 0.3.1
english 0.7.1
erb 2.2.0
strscan 3.0.1
abbrev 0.1.0
io-console 0.5.7
tempfile 0.1.1
delegate 0.2.0
fileutils 1.5.0
tmpdir 0.1.2
base64 0.1.0
singleton 0.1.1
net-http 0.1.1
open3 0.1.1
nkf 0.1.0
prettyprint 0.1.1
pp 0.2.1
find 0.1.0
yaml 0.1.1
psych 3.3.2

generated on: 2022-02-02

@saifudheenvk
Copy link

saifudheenvk commented Feb 7, 2022

@SwiftiSwift I have the same issue on the latest versions. when i try to upload app in circleci. But it's working in my local machine with version 2.204
[In circle ci it works with version 2.197]

@ChaosCoder
Copy link
Contributor

Still happening with fastlane 2.204.3. Using 2.197.0 still works.

2.204.3/fastlane_core/lib/fastlane_core/itunes_transporter.rb:506:in `extname': \e[31m[!] no implicit conversion of true into String\e[0m (TypeError)

The complete stacktrace:

Traceback (most recent call last):
	45: from /Users/Andreas/.rbenv/versions/2.7.4/bin/bundle:23:in `<main>'
	44: from /Users/Andreas/.rbenv/versions/2.7.4/bin/bundle:23:in `load'
	43: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/bundler-2.2.32/exe/bundle:37:in `<top (required)>'
	42: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/bundler-2.2.32/lib/bundler/friendly_errors.rb:103:in `with_friendly_errors'
	41: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/bundler-2.2.32/exe/bundle:49:in `block in <top (required)>'
	40: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/bundler-2.2.32/lib/bundler/cli.rb:25:in `start'
	39: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/bundler-2.2.32/lib/bundler/vendor/thor/lib/thor/base.rb:485:in `start'
	38: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/bundler-2.2.32/lib/bundler/cli.rb:31:in `dispatch'
	37: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/bundler-2.2.32/lib/bundler/vendor/thor/lib/thor.rb:392:in `dispatch'
	36: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/bundler-2.2.32/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
	35: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/bundler-2.2.32/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
	34: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/bundler-2.2.32/lib/bundler/cli.rb:478:in `exec'
	33: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/bundler-2.2.32/lib/bundler/cli/exec.rb:23:in `run'
	32: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/bundler-2.2.32/lib/bundler/cli/exec.rb:58:in `kernel_load'
	31: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/bundler-2.2.32/lib/bundler/cli/exec.rb:58:in `load'
	30: from /Users/Andreas/.rbenv/versions/2.7.4/bin/fastlane:23:in `<top (required)>'
	29: from /Users/Andreas/.rbenv/versions/2.7.4/bin/fastlane:23:in `load'
	28: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/fastlane-2.204.3/bin/fastlane:23:in `<top (required)>'
	27: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/fastlane-2.204.3/fastlane/lib/fastlane/cli_tools_distributor.rb:122:in `take_off'
	26: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/fastlane-2.204.3/fastlane/lib/fastlane/commands_generator.rb:42:in `start'
	25: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/fastlane-2.204.3/fastlane/lib/fastlane/commands_generator.rb:353:in `run'
	24: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/commander-4.6.0/lib/commander/delegates.rb:18:in `run!'
	23: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/fastlane-2.204.3/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:124:in `run!'
	22: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/commander-4.6.0/lib/commander/runner.rb:444:in `run_active_command'
	21: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/commander-4.6.0/lib/commander/command.rb:157:in `run'
	20: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/commander-4.6.0/lib/commander/command.rb:187:in `call'
	19: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/fastlane-2.204.3/fastlane/lib/fastlane/commands_generator.rb:109:in `block (2 levels) in run'
	18: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/fastlane-2.204.3/fastlane/lib/fastlane/command_line_handler.rb:36:in `handle'
	17: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/fastlane-2.204.3/fastlane/lib/fastlane/lane_manager.rb:47:in `cruise_lane'
	16: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/fastlane-2.204.3/fastlane/lib/fastlane/runner.rb:45:in `execute'
	15: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/fastlane-2.204.3/fastlane/lib/fastlane/runner.rb:45:in `chdir'
	14: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/fastlane-2.204.3/fastlane/lib/fastlane/runner.rb:49:in `block in execute'
	13: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/fastlane-2.204.3/fastlane/lib/fastlane/lane.rb:33:in `call'
	12: from Fastfile:114:in `block (2 levels) in parsing_binding'
	11: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/fastlane-2.204.3/fastlane/lib/fastlane/fast_file.rb:159:in `method_missing'
	10: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/fastlane-2.204.3/fastlane/lib/fastlane/runner.rb:157:in `trigger_action_by_name'
	 9: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/fastlane-2.204.3/fastlane/lib/fastlane/runner.rb:229:in `execute_action'
	 8: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/fastlane-2.204.3/fastlane/lib/fastlane/runner.rb:229:in `chdir'
	 7: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/fastlane-2.204.3/fastlane/lib/fastlane/runner.rb:255:in `block in execute_action'
	 6: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/fastlane-2.204.3/fastlane/lib/fastlane/actions/actions_helper.rb:69:in `execute_action'
	 5: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/fastlane-2.204.3/fastlane/lib/fastlane/runner.rb:263:in `block (2 levels) in execute_action'
	 4: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/fastlane-2.204.3/fastlane/lib/fastlane/actions/upload_to_app_store.rb:22:in `run'
	 3: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/fastlane-2.204.3/deliver/lib/deliver/runner.rb:59:in `run'
	 2: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/fastlane-2.204.3/deliver/lib/deliver/runner.rb:189:in `upload_binary'
	 1: from /Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/fastlane-2.204.3/fastlane_core/lib/fastlane_core/itunes_transporter.rb:506:in `upload'
/Users/Andreas/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/fastlane-2.204.3/fastlane_core/lib/fastlane_core/itunes_transporter.rb:506:in `extname': \e[31m[!] no implicit conversion of true into String\e[0m (TypeError)

@saifudheenvk
Copy link

saifudheenvk commented Feb 18, 2022

@ChaosCoder Any updates?

@GeylanKalafMohe
Copy link

I don't understand why no team member of @fastlaneTeam responds on this issue

@snatchev
Copy link
Member

snatchev commented Mar 9, 2022

the asset_path parameter is true whereas the code expects a string of a filepath.

This line looks like a logic operation that could result in a boolean getting passed in. I am not clear on the original intention of that code, but I suspect that is where the problem is stemming from.

Edit: Here the upload_ipa and upload_pkg are set to booleans. Can we confirm this error only happens when both .ipa and .pkg files exist?

@rahul0x24
Copy link

I can confirm that the fastlane mac build breaks only when an ipa file exists.

After your suggestion, I deleted the ipa and the build uploaded successfully.

Thanks @snatchev

@krzysiek84
Copy link
Contributor

krzysiek84 commented Mar 23, 2022

I can confirm @snatchev findings, there is a conversion to Boolean when both ipa and pkg is set. My solution is slightly different i've introduced asset_path variable, and set it in if blocks.

def upload_binary
      UI.message("Uploading binary to App Store Connect")
      
      upload_ipa = options[:ipa]
      upload_pkg = options[:pkg]

      # 2020-01-27
      # Only verify platform if if both ipa and pkg exists (for backwards support)
      if upload_ipa && upload_pkg
        upload_ipa = ["ios", "appletvos"].include?(options[:platform])
        upload_pkg = options[:platform] == "osx"
      end

      if upload_ipa
        package_path = FastlaneCore::IpaUploadPackageBuilder.new.generate(
          app_id: Deliver.cache[:app].id,
          ipa_path: options[:ipa],
          package_path: "/tmp",
          platform: options[:platform]
        )
        asset_path = options[:ipa]
      elsif upload_pkg
        package_path = FastlaneCore::PkgUploadPackageBuilder.new.generate(
          app_id: Deliver.cache[:app].id,
          pkg_path: options[:pkg],
          package_path: "/tmp",
          platform: options[:platform]
        )
        asset_path = options[:pkg]
      end

      transporter = transporter_for_selected_team
      result = transporter.upload(package_path: package_path, asset_path: asset_path)

      unless result
        transporter_errors = transporter.displayable_errors
        UI.user_error!("Error uploading ipa file: \n #{transporter_errors}")
      end
    end

@ChaosCoder
Copy link
Contributor

I can also confirm, that deleting the existing .pkg when using deliver with an iOS app fixes the crash.

Would be nice to see one of those fixes implemented. Any chance to turn those snippts and drafts into reviewable PRs @snatchev and @krzysiek84?

@GeylanKalafMohe
Copy link

Why is it so hard to just publish a fix that deletes the .pkg file before fastlane does its stuff...

@krzysiek84
Copy link
Contributor

krzysiek84 commented Apr 8, 2022

@ChaosCoder the PR is already as a draft created by @snatchev.
I was in a hurry so tried to tweak the code with minimal changes possible and edited my fastlane install.

Edit: here is link to the draft: #20043

@fastlane-bot
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest fastlane version and check if that solves the issue. Let us know if that works for you by adding a comment 👍

Friendly reminder: contributions are always welcome! Check out CONTRIBUTING.md for more information on how to help with fastlane and feel free to tackle this issue yourself 💪

This issue will be auto-closed if there is no reply within 1 month.

@saifudheenvk
Copy link

Still i'm facing this issue. @fastlane-bot why are you delaying for a release with a fix

@snatchev
Copy link
Member

I have PR #20043 up for review, it should fix this issue.

@mezhevikin
Copy link

@snatchev Any news?

@snatchev
Copy link
Member

@mezhevikin gentle ping @joshdholtz or perhaps @crazymanish for review on #20043 :)

snatchev added a commit that referenced this issue Jun 29, 2022
…20043)

* Update deliver/runner.rb to handle both ipa and pkg paths.

#19659

* Update runner.rb

* reformat

* Update runner.rb

* Updated verify to use same logic

* Fix verify message when no valid platform

Co-authored-by: Josh Holtz <me@joshholtz.com>
@fastlane-bot
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest fastlane version and check if that solves the issue. Let us know if that works for you by adding a comment 👍

Friendly reminder: contributions are always welcome! Check out CONTRIBUTING.md for more information on how to help with fastlane and feel free to tackle this issue yourself 💪

This issue will be auto-closed if there is no reply within 1 month.

@snatchev
Copy link
Member

#20043 has been closed and released. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests