New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[match] Add support for Developer ID certificates from G2 Sub-CA #20145
[match] Add support for Developer ID certificates from G2 Sub-CA #20145
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
This comment was marked as spam.
This comment was marked as spam.
Thanks! Btw. the CLA is signed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this! Did you happen to test this to see how this behaves with App Store Connect API?
The official docs don't show this as a value (yet) - https://developer.apple.com/documentation/appstoreconnectapi/certificatetype
I don't think you can create a Developer ID while using the API Key but wanted to check anyway 🙃
Thanks for your feedback @joshdholtz! Could you give me a hint how to test this with the ASC API? It’s a bit tricky to test this as you can only have one Developer ID cert, and I think you can’t even revoke it. Any guidance how to deal with this would be appreciated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I tested this with both Apple ID auth and API Key and works as expected 💪 I also added a commit so that it will still list cert of both the new and old type but will only create the new one.
Really appreciate the contribution 🥰
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations! 🎉 This was released as part of fastlane 2.206.0 🚀
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
Developer ID certificates can now be generated using one of two different intermediary CAs, and Fastlane currently doesn’t support the newer G2 Sub-CA. Following is the description from the certification creation page on the Apple Developer portal when selecting "Developer ID Application":
Description
DEVELOPER_ID_APPLICATION_G2
certificate typematch
andsigh
to find Developer ID certificates using this new typecert
to generate Developer ID certificates using this new typeI used
match
to generate and find a new Developer ID certificate.