Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for iPhone 13 device family with updated colors #20148

Merged
merged 1 commit into from Apr 10, 2022

Conversation

casperson
Copy link
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Add support for the iPhone 13 family of devices (13, 13 Pro, 13 Pro Max, 13 Mini) to frameit

Description

Add support for the iPhone 13 family of devices (13, 13 Pro, 13 Pro Max, 13 Mini) to frameit

  • Added 3 new colors in frameit/devices_type.rb (Midnight, Starlight, Sierra)

  • Added 4 new devices in frameit/devices_type.rb (iPhone 13, iPhone 13 Pro, iPhone 13 Pro Max, iPhone 13 Mini)

Related: fastlane/frameit-frames#27

The above added the actual frame images.

Testing Steps

To test this branch, modify your Gemfile as:

gem "fastlane", :git => "https://github.com/casperson/fastlane.git", :branch => "frameit-add-iphone13-devices"
And run bundle install to apply the changes.

@google-cla
Copy link

google-cla bot commented Apr 6, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for adding this 😊

@joshdholtz joshdholtz merged commit e9861e6 into fastlane:master Apr 10, 2022
@fastlane-bot
Copy link

Hey @casperson 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.205.2 🚀

@fastlane fastlane locked and limited conversation to collaborators Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants